Add TCNN_HALF_PRECISION definition to RTC-kernel#529
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #528 by adding the TCNN_HALF_PRECISION macro definition to runtime-compiled CUDA kernels. The generated RTC kernels include common.h (via common_device.h in the preamble), which has a compile-time check requiring TCNN_HALF_PRECISION to be defined. Without this definition, the RTC compilation would fail.
Key Changes:
- Added
#define TCNN_HALF_PRECISION {TCNN_HALF_PRECISION}to the kernel template before any includes - Added the corresponding named argument
"TCNN_HALF_PRECISION"_a = TCNN_HALF_PRECISIONto the dfmt call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
julcst
changed the title
Contributor
|
Thanks! I made a minor adjustment before merging (moved the definition to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528