Documentation#230
Open
azrael417 wants to merge 82 commits into
Open
Conversation
Add docs/_static/custom.css recoloring the pydata-sphinx-theme accents (links, active nav, primary/secondary, inline code, header top border) to NVIDIA green #76B900 on white, in both light and dark modes, and wire it in via html_css_files in conf.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bump actions/checkout v4->v5 and actions/setup-python v5->v6 across all workflows, and in style.yml replace pre-commit/action@v3.0.1 (whose bundled sub-actions still target the deprecated Node.js 20 runtime) with a direct pre-commit run plus actions/cache@v5. Clears the Node.js 20 deprecation warnings on GitHub Actions runners. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
azrael417
marked this pull request as ready for review
July 14, 2026 11:47
bonevbs
reviewed
Jul 16, 2026
bonevbs
left a comment
Collaborator
There was a problem hiding this comment.
A few comments:
- for the plots in the examples can we use
plot_sphereinstead ofimshow? - can we rename the headings "Attention" to "Attention Mechanism"?
- in the bibliography, can we change the order of papers based on relevance? I would start with Nathanael Schaeffer's paper which is the fundamental SHT algorithm we implement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a full Sphinx documentation site for torch-harmonics covering API reference, user guides, tutorials, and build instructions.
API reference
User guides
Tutorials
Build & install documentation
Benchmarking
Docstring quality
Other changes
Test plan
python -m pytest --ignore-glob="**/test_distributed_*" ./tests/)--reference-archflag works:python benchmarks/run.py --reference-csv <file> --reference-arch <arch>