Skip to content

feat(nvca): add first-class BYOO chart values - #970

Draft
kristinapathak wants to merge 1 commit into
mainfrom
kpathak/feat-nvca-first-class-byoo-values
Draft

feat(nvca): add first-class BYOO chart values#970
kristinapathak wants to merge 1 commit into
mainfrom
kpathak/feat-nvca-first-class-byoo-values

Conversation

@kristinapathak

Copy link
Copy Markdown
Collaborator

TL;DR

  • Adds typed top-level byoo values for collector resources, log chunking, collector rendering, and capacity overhead.
  • Renders those values into the existing agent config ConfigMap, so other generated configuration remains intact.
  • Keeps legacy BYOO fields in agentConfig.mergeConfig for one minor release. Legacy values take precedence during the transition and cause a once-per-resource-version operator warning.

Additional Details

The generated Helm chart is regenerated from the native source. The native chart now carries an existing PodDisruptionBudget template and defaults so vending preserves current chart output.

For the Reviewer

Please review the chart composition helpers and ConfigMap template, the RBAC reader using the composed config, and the operator warning guard.

For QA

  • Passed helm lint, make test-first-class-byoo-values, make test-self-managed-nvca-image-reference, make lint, and make validate.
  • Passed focused Go test for the warning guard.
  • go test ./pkg/operator/reconcile is blocked by the existing test harness inability to patch os.Exit in this environment.
  • QA needed: No. Render and focused unit coverage are included.

Issues

Closes #969

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 12a1aace-a393-4293-9b07-0733e85f63a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(nvca): add first-class BYOO chart configuration

1 participant