fix(nvca-operator): use NGC core BYOO image - #1040
Draft
kristinapathak wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Route the staging BYOO OpenTelemetry Collector default to the NGC core repository so NCP function and task sidecars use the repository granted to their deployment credential.
Additional Details
The chart derived the staging collector location from the operator repository. This selected a different repository from the one configured for the collector artifact.
The source chart and generated release chart now use
stg.nvcr.io/nv-cf/nvcf-core/byoo-otel-collectorfor staging defaults. Explicit BYOO collector image overrides still take precedence.For the Reviewer
Please review the staging fallback and its rendered-image regression assertion.
For QA
make test-self-managed-nvca-image-referencemake lintmake test-release-image-manifestQA needed: No. The chart rendering test covers both function and task overrides.
Issues
Relates to #1039
Checklist
Github commit:
5117640