feat(stargate): add configurable Pulsar input TPS weights - #1002
Draft
barrygreengus wants to merge 3 commits into
Draft
feat(stargate): add configurable Pulsar input TPS weights#1002barrygreengus wants to merge 3 commits into
barrygreengus wants to merge 3 commits into
Conversation
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🛡️ CodeQL Analysis🚨 Found 2 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-08-19 15:47:50 UTC | Commit: f00fe01 |
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pulsar rendezvous weighting needs to support either the current mean input TPS or the maximum input TPS observed for a backend generation. Benchmark coverage must exercise measured throughput instead of forcing Pylon to report configured performance values.
What changed
Customer Release Notes
Pulsar routing can use either current mean or generation maximum input throughput as its rendezvous weight.
Plan Summary
Not applicable.
Usage
Set rendezvous_weight to max-input-tps on a Pulsar or Pulsar wait-and-widen algorithm configuration. Omit it to keep last-mean-input-tps.
Testing
QA is not required beyond automated coverage.
Notes
The maximum persists for one model generation and resets with generation replacement. It has no time window and max mode does not fall back to mean when maximum data is incomplete.
References
Closes #1001
Related Pull Requests
None.
Dependencies
None. No license or NOTICE changes.