[codex] Add scalar pointer out-return support#344
Draft
isVoid wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds scalar pointer output support for out_return argument intents. APIs with output parameters such as unsigned int* singleMipLevel can now be exposed as returned scalar values, so a C++ shape like uint4 texture_footprint(..., unsigned int*) can compile to a Numba-facing tuple result like (footprint, single_mip).
The implementation records which out_return parameters are pointer outputs, derives the returned Numba type from the pointee type, allocates hidden scalar storage, passes the expected pointer slot through the shim ABI, and materializes the scalar after the call. The same helper path is wired through dynamic functions, templated functions, struct/class-template methods, and static binding rendering.
Validation
CUDA end-to-end tests were attempted locally but the environment has no CUDA device (CUDA_ERROR_NO_DEVICE).