[codex] Add pointer-backed return materialization#342
Draft
isVoid wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit pointer-backed return materialization path for APIs that return borrowed fixed-size pointer data, such as
const float4* get_transform(handle). Configured functions now expose a Numba-visibleUniTuple(pointee, length)return, with lowering copying the configured number of elements from the returned pointer.Changes
PointerReturnMaterializationand config parsing for dynamic and static binding paths.FunctionCallConvto load fixed-size pointee data from the C++ return pointer and materialize it as a tuple return.Function Return Materializations, including schema and generated schema docs.const float4*return materialized asUniTuple(float32x4, 3).Validation
PYTHONPATH=/home/wangm/numbast-optix/numbast-pointer-backed-return/numbast/src:/home/wangm/numbast-optix/numbast-pointer-backed-return/ast_canopy pytest -q numbast/tests/test_callconv.py numbast/tests/test_function.py::test_pointer_return_binding_signature numbast/src/numbast/static/tests/test_function_static_bindings.py::test_pointer_return_static_binding_source numbast/src/numbast/static/tests/test_function_static_bindings.py::test_generated_callconv_alignof_helper_is_standalone numbast/src/numbast/tools/tests/test_config_schema_docs.py12 passed in 0.87sCUDA execution tests were added but could not be run on this machine because CUDA initialization reports
CUDA_ERROR_NO_DEVICE.