BUG: Fix CUDADispatcher.compile_device ignoring abi flag#891
Open
acosmicflamingo wants to merge 2 commits into
Open
BUG: Fix CUDADispatcher.compile_device ignoring abi flag#891acosmicflamingo wants to merge 2 commits into
acosmicflamingo wants to merge 2 commits into
Conversation
Author
|
After seeing that there was an individual test module for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #890
Although most of
cuda.jit's flags make their way down toCUDADispatcher'scompile_cudafunction, theabiflag was not one of them. It is properly handled in the internal compile function here however (hence @shwina's reproducer).Only guidance I need is whether a test for this should go in a module that tests
cuda.jitor the compiler functionality.