Skip to content

Move publish step out of wheels-build.yaml#147

Merged
gmarkall merged 3 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:refactor-publish-step
Mar 6, 2025
Merged

Move publish step out of wheels-build.yaml#147
gmarkall merged 3 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:refactor-publish-step

Conversation

@KyleFromNVIDIA

@KyleFromNVIDIA KyleFromNVIDIA commented Mar 5, 2025

Copy link
Copy Markdown
Member

Also change an instance of mambabuild to build.

Follow-up to #142 (comment)

@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

This job shows that the wheels are successfully downloaded from the reusable workflow when required. I am removing the fake-publish-wheels job.

@gmarkall gmarkall added the 3 - Ready for Review Ready for review by team label Mar 6, 2025
@gmarkall gmarkall merged commit d7e6fa3 into NVIDIA:main Mar 6, 2025
@gmarkall gmarkall added 5 - Ready to merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 6, 2025
@webknjaz

webknjaz commented Mar 6, 2025

Copy link
Copy Markdown

@gmarkall @KyleFromNVIDIA this is partially what I meant. The move is correct. The next step would be to set up environment and OIDC privileges, get rid of the token and set up trust on PyPI.
Without that, you're not going to get metadata marked as verified and the attestations won't be produced either — they rely on OIDC too.

gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Mar 6, 2025
- Fix linking of external code from callees (NVIDIA#137)
- Try using a newer branch workflow (NVIDIA#148)
- Move publish step out of `wheels-build.yaml` (NVIDIA#147)
- Upload wheels to PyPI from GitHub-hosted runner (NVIDIA#142)
- Add paddle to interoperability chapter (NVIDIA#144)
- Fix the debug info of GridGroup type (NVIDIA#131)
- Remove dead `prepare_cuda_kernel()` (NVIDIA#130)
- Add a CUDA DI Builder (NVIDIA#104)
- dont launch extra kernels when stats counting is disabled (NVIDIA#127)
- Fixup debug metadata in kernel fixup (NVIDIA#97)
- Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (NVIDIA#106)
@gmarkall gmarkall mentioned this pull request Mar 6, 2025
gmarkall added a commit that referenced this pull request Mar 6, 2025
- Fix linking of external code from callees (#137)
- Try using a newer branch workflow (#148)
- Move publish step out of `wheels-build.yaml` (#147)
- Upload wheels to PyPI from GitHub-hosted runner (#142)
- Add paddle to interoperability chapter (#144)
- Fix the debug info of GridGroup type (#131)
- Remove dead `prepare_cuda_kernel()` (#130)
- Add a CUDA DI Builder (#104)
- dont launch extra kernels when stats counting is disabled (#127)
- Fixup debug metadata in kernel fixup (#97)
- Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (#106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Testing and reviews complete, ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants