Skip to content

fix(version): prevent panic on empty or invalid version string in Compare #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lockwobr merged 1 commit into from
Sep 21, 2026
Merged

fix(version): prevent panic on empty or invalid version string in Compare #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion operator/internal/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,12 @@ func IsValid(version string) bool {
return semver.IsValid(version)
}

// Compare compares two versions and returns 0 if they are equal, 1 if version1 is greater than version2, -1 if version1 is less than version2
// Compare compares two versions and returns 0 if they are equal, 1 if version1 is greater than version2, -1 if version1 is less than version2,
// or -2 if either version is invalid or empty.
func Compare(version1, version2 string) int {
if !IsValid(version1) || !IsValid(version2) {
return -2
}
if version1[0] != 'v' {
version1 = "v" + version1
}
Expand Down
5 changes: 5 additions & 0 deletions operator/internal/version/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ var _ = Describe("version", func() {
Entry("left is older", "v1.2.3", "v1.3.0", -1),
Entry("left is newer", "v2.0.0", "v1.9.9", 1),
Entry("prerelease sorts before its release", "v1.2.3-rc.1", "v1.2.3", -1),
Entry("empty on the right returns -2", "v1.2.3", "", -2),
Entry("empty on the left returns -2", "", "v1.2.3", -2),
Entry("empty on both sides returns -2", "", "", -2),
Entry("invalid on the left returns -2", "dev", "v1.2.3", -2),
Entry("invalid on the right returns -2", "v1.2.3", "dev", -2),
)
})

Expand Down
Loading