Skip to content

fix(agent): Implement BGP uplink health checks for NVUE REST client - #5101

Merged
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
DrewBloechl:drew/backport-5075-to-v2.1
Aug 18, 2026
Merged

fix(agent): Implement BGP uplink health checks for NVUE REST client#5101
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
DrewBloechl:drew/backport-5075-to-v2.1

Conversation

@DrewBloechl

Copy link
Copy Markdown
Contributor

This is a backport to v2.1 of #5075; the original text of that merge follows:

This implements the BGP uplink health checks that didn't get ported over when I did the initial NVUE REST client work for DPF. This breaks down like so:

  • Add new NvueClient methods to fetch per-VRF BGP data (using the OpenAPI spec to generate the types).
  • Add health::nvue::check_bgp_uplink_sessions to implement health checks from the above BGP data.
  • Rework the NVUE REST health checks to call this after checking whether the REST API is up.

Related issues

  • Internal NVBugs ID 6563638

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

…VIDIA#5075)

This is a backport to v2.1 of NVIDIA#5075; the original text of that merge
follows:

This implements the BGP uplink health checks that didn't get ported over
when I did the initial NVUE REST client work for DPF. This breaks down
like so:
- Add new `NvueClient` methods to fetch per-VRF BGP data (using the
OpenAPI spec to generate the types).
- Add `health::nvue::check_bgp_uplink_sessions` to implement health
checks from the above BGP data.
- Rework the NVUE REST health checks to call this after checking whether
the REST API is up.

- Internal NVBugs ID 6563638

- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [X] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

- [ ] **This PR contains breaking changes**

- [X] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)
@DrewBloechl
DrewBloechl requested a review from a team August 18, 2026 16:52
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d298b472-8b3d-4062-82c7-11f9f10a1087

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-18 16:55:17 UTC | Commit: 9a5e6e3

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backports needed fix

@nv-dmendoza
nv-dmendoza merged commit 1deedaa into NVIDIA:release/v2.1 Aug 18, 2026
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants