fix(agent): Implement BGP uplink health checks for NVUE REST client - #5101
Conversation
…VIDIA#5075) This is a backport to v2.1 of NVIDIA#5075; the original text of that merge follows: This implements the BGP uplink health checks that didn't get ported over when I did the initial NVUE REST client work for DPF. This breaks down like so: - Add new `NvueClient` methods to fetch per-VRF BGP data (using the OpenAPI spec to generate the types). - Add `health::nvue::check_bgp_uplink_sessions` to implement health checks from the above BGP data. - Rework the NVUE REST health checks to call this after checking whether the REST API is up. - Internal NVBugs ID 6563638 - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [X] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) - [ ] **This PR contains breaking changes** - [X] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-18 16:55:17 UTC | Commit: 9a5e6e3 |
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, backports needed fix
This is a backport to v2.1 of #5075; the original text of that merge follows:
This implements the BGP uplink health checks that didn't get ported over when I did the initial NVUE REST client work for DPF. This breaks down like so:
NvueClientmethods to fetch per-VRF BGP data (using the OpenAPI spec to generate the types).health::nvue::check_bgp_uplink_sessionsto implement health checks from the above BGP data.Related issues
Type of Change
Breaking Changes
Testing