Skip to content

fix(auth): allow anonymous callers to GetJWKS and GetOpenIDConfiguration #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdachepally wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix(auth): allow anonymous callers to GetJWKS and GetOpenIDConfiguration #5064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af2209
fix(auth): allow anonymous callers to GetJWKS and GetOpenIDConfiguration
sdachepally Aug 17, 2026
07405bd
add regression test for anonymous access to GetJWKS and GetOpenIDConf…
sdachepally Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions crates/api-core/src/auth/internal_rbac_rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,8 +943,8 @@ impl InternalRBACRules {
pub(super) fn allowed(&self, msg: &str, user_principals: &[crate::auth::Principal]) -> bool {
if let Some(perm_info) = self.perms.get(msg) {
if user_principals.is_empty() {
// No proper cert presented, but we will allow stuff that allows just Anonymous
return perm_info.principals.as_slice() == [Principal::Anonymous];
// No proper cert presented, but we allow any rule that lists Anonymous.
return perm_info.principals.contains(&Principal::Anonymous);

@sunilkumar-nvidia sunilkumar-nvidia Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a regression test for this case? The existing anonymous test covers a rule containing only Anonymous (DiscoverMachine), while this fix is specifically for rules where Anonymous appears alongside other principals. An assertion that certless requests can access GetJWKS and GetOpenIDConfiguration would prevent this from regressing.

}
user_principals.iter().any(|user_principal| {
perm_info
Expand Down Expand Up @@ -1101,6 +1101,17 @@ mod rbac_rule_tests {
));
}

#[test]
fn anonymous_rules_allow_certless_callers() {
// Certless callers must be allowed when a rule lists Anonymous among other principals.
for method in ["GetJWKS", "GetOpenIDConfiguration"] {
assert!(
InternalRBACRules::allowed_from_static(method, &[]),
"{method}"
);
}
}

#[test]
fn rbac_rule_tests() -> Result<(), eyre::Report> {
assert!(InternalRBACRules::allowed_from_static(
Expand Down
Loading