Skip to content

Port Lingbot to new API - #425

Merged
aidanfnv merged 5 commits into
NVIDIA:dev/jarcher/inference-runtime-apifrom
aidanfnv:dev/aidanf/inference-runtime-api-lingbot
Aug 7, 2026
Merged

Port Lingbot to new API#425
aidanfnv merged 5 commits into
NVIDIA:dev/jarcher/inference-runtime-apifrom
aidanfnv:dev/aidanf/inference-runtime-api-lingbot

Conversation

@aidanfnv

@aidanfnv aidanfnv commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Lacks WIP webrtc changes

aidanfnv and others added 4 commits August 6, 2026 16:42
Pin the runtime-API camera path against the WebRTC path it will replace.
KeyboardResampler + CameraPoseIntegrator and the canonicalizer + mapping
path are compared over 11 key streams, single- and multi-chunk, including
edges landing exactly on a chunk boundary where KeyboardResampler's
inclusive drain meets TimeWindow's half-open slice. They agree.

Also cover event-driven camera control on CUDA, and repair the existing
CUDA test, which monkeypatched trace-loading helpers that moved out of
the session and called step() with an empty InferenceInput.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Ports Lingbot replay and WebRTC serving to the shared inference-runtime demo API.

  • Adds Lingbot runtime, input mapping, scenario, CLI, replay, and WebRTC adapters.
  • Updates the serving output target to launch the shared Lingbot demo CLI.
  • Adds coverage for demo APIs, mappings, keyboard parity, runtime inputs, GPU behavior, and smoke paths.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
integrations/lingbot/lingbot/runtime.py Introduces the shared Lingbot runtime and replay conversion helpers; the previously reported unreachable conversion return is removed correctly.
integrations/lingbot/lingbot/input_mapping.py Adds canonical keyboard/text-event conversion and camera trajectory mapping for replay and live control.
integrations/lingbot/lingbot/demo/adapter.py Connects Lingbot scenarios, mappings, runtimes, and output modes to the shared demo API.
integrations/lingbot/lingbot/demo/cli.py Adds replay and WebRTC commands that construct shared DemoSpec configurations.
flashdreams/flashdreams/serving/output_targets.py Redirects Lingbot WebRTC launches to the new shared demo CLI and argument contract.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  CLI[Lingbot demo CLI] --> Spec[DemoSpec]
  Spec --> Adapter[LingbotDemoAdapter]
  Adapter --> Mapping[LingbotInputMapping]
  Adapter --> Runtime[Lingbot runtime]
  Mapping --> Runtime
  Runtime --> MP4[MP4 output]
  Runtime --> WebRTC[WebRTC session]
Loading

Reviews (2): Last reviewed commit: "Update integrations/lingbot/lingbot/runt..." | Re-trigger Greptile

Comment thread integrations/lingbot/lingbot/runtime.py Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: aidanfnv <aidanf@nvidia.com>
@aidanfnv
aidanfnv merged commit 5e9d60b into NVIDIA:dev/jarcher/inference-runtime-api Aug 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant