Port Lingbot to new API - #425
Merged
aidanfnv merged 5 commits intoAug 7, 2026
Merged
Conversation
Pin the runtime-API camera path against the WebRTC path it will replace. KeyboardResampler + CameraPoseIntegrator and the canonicalizer + mapping path are compared over 11 key streams, single- and multi-chunk, including edges landing exactly on a chunk boundary where KeyboardResampler's inclusive drain meets TimeWindow's half-open slice. They agree. Also cover event-driven camera control on CUDA, and repair the existing CUDA test, which monkeypatched trace-loading helpers that moved out of the session and called step() with an empty InferenceInput. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Greptile SummaryPorts Lingbot replay and WebRTC serving to the shared inference-runtime demo API.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI[Lingbot demo CLI] --> Spec[DemoSpec]
Spec --> Adapter[LingbotDemoAdapter]
Adapter --> Mapping[LingbotInputMapping]
Adapter --> Runtime[Lingbot runtime]
Mapping --> Runtime
Runtime --> MP4[MP4 output]
Runtime --> WebRTC[WebRTC session]
Reviews (2): Last reviewed commit: "Update integrations/lingbot/lingbot/runt..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: aidanfnv <aidanf@nvidia.com>
aidanfnv
merged commit Aug 7, 2026
5e9d60b
into
NVIDIA:dev/jarcher/inference-runtime-api
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lacks WIP webrtc changes