Added VFCount to the HTTP POST route /configure-host-vfs#49
Open
eelgaev wants to merge 4 commits into
Open
Conversation
AddNetworkRequest returned early when a request already existed, ignoring the provided vfCount. Now updates NumOfVFs and persists the change so the next processing cycle applies it.
Author
|
Tested, It fully work as expected. |
Contributor
|
Need update the existing tests and add coverage for the new |
Author
|
Added some tests |
langyenan
reviewed
Jun 2, 2026
| nm.reqs[existing.UID] = existing | ||
| klog.Infof("Updated VF count to %d for DPU %s/%s", *vfCount, existing.DPUNamespace, existing.DpuName) | ||
| } | ||
| return nil |
Contributor
There was a problem hiding this comment.
I believe nm.getNumOfVFs(dpu) should be called here in the case of vfCount == nil. Otherwise, during Host Network Configuration phase, the host-agent will ignore the value in the DPUFlavor
Author
There was a problem hiding this comment.
You are right, I pushed a fix now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional value (
vfCount) to the/configure-host-vfsHTTP POST route, it will create the specified VF count on the host. IfvfCountwas not set, it will keep setting the same value that is set in DPUFlavor.