Skip to content

TEST: Address Python test optimization review feedback - #24098

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:codex/test-review-feedback
Sep 10, 2026
Merged

TEST: Address Python test optimization review feedback#24098
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:codex/test-review-feedback

Conversation

@vyasr

@vyasr vyasr commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses small review follow-ups from these merged Python test optimization PRs:

This is a test-only follow-up that incorporates the agreed small cleanup suggestions without changing the intended test coverage.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 9, 2026 22:32
@vyasr vyasr added the tests Unit testing for project label Sep 9, 2026
@vyasr
vyasr requested a review from galipremsagar September 9, 2026 22:32
@vyasr vyasr added Python Affects Python cuDF API. Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project labels Sep 9, 2026
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d7269ca7-d82c-44ca-8434-ab31e24546b9

📥 Commits

Reviewing files that changed from the base of the PR and between f4e3c21 and 727393c.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/series/methods/test_cov_corr.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded MultiIndex sorting coverage across axis aliases, index resetting, and in-place operations.
    • Added broader string concatenation coverage, including elementwise inputs.
    • Consolidated covariance and correlation test data handling while preserving existing test cases.
    • Simplified test parameter definitions without changing the behavior being tested.

Walkthrough

The changes consolidate pytest parameterization, expand MultiIndex sorting and index string concatenation coverage, and replace shared covariance/correlation parameter data with a module-scoped fixture.

Changes

Test parameterization updates

Layer / File(s) Summary
MultiIndex sort parameter matrix
python/cudf/cudf/tests/dataframe/methods/test_sort_index.py
The sort-index test now covers axis aliases, lifecycle options, ordering, and missing-value placement in one parameter matrix.
Concatenation parameter cases
python/cudf/cudf/tests/reshape/test_concat.py, python/cudf/cudf/tests/series/accessors/test_str.py
Concatenation tests use direct tuple parameters. Index string concatenation now includes list inputs through the shared assertion helper.
Covariance and correlation fixture
python/cudf/cudf/tests/series/methods/test_cov_corr.py
Covariance and correlation tests use a shared module-scoped fixture for paired input data.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 72739

This test-only change consolidates parameter handling and expands targeted coverage without changing product behavior. No concrete merge-blocking risk remains.

Suggested reviewers: mroeschke

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a test-only change that addresses review feedback from Python test optimization work.
Description check ✅ Passed The description directly matches the test cleanup changes and explains that intended coverage remains unchanged.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@vyasr
vyasr force-pushed the codex/test-review-feedback branch from f4e3c21 to 727393c Compare September 10, 2026 01:27
@rapids-bot
rapids-bot Bot merged commit b260b30 into NVIDIA:main Sep 10, 2026
184 of 188 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 10, 2026
@vyasr
vyasr deleted the codex/test-review-feedback branch September 10, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants