Skip to content

test: reduce JSON multi-batch coverage - #24043

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/optimize-json-multibatch-tests
Open

test: reduce JSON multi-batch coverage#24043
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/optimize-json-multibatch-tests

Conversation

@vyasr

@vyasr vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Keep the representative small and large JSON multi-batch chunk sizes while removing redundant middle sizes. The remaining cases still exercise many batches and a range exceeding one batch.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 8, 2026 21:18
@vyasr vyasr added tests Unit testing for project cuIO cuIO issue Performance Performance related issue labels Sep 8, 2026
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7bc324d7-c5b9-4323-8c81-4a848fb04d1f

📥 Commits

Reviewing files that changed from the base of the PR and between 89dac81 and 3d61bed.

📒 Files selected for processing (1)
  • cpp/tests/large_strings/json_tests.cpp

Included review availability: Your plan provides up to 12 included reviews per hour; 4 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests

    • Updated large-string JSON test coverage for multi-batch ranges.
    • Tests now focus on small ranges and oversized ranges; intermediate half-batch and single-batch scenarios are no longer covered.
  • Documentation

    • Updated copyright year information in the test documentation.

Walkthrough

The JSON large-string test updates the copyright notice and revises MultiBatch coverage to document and test small multi-batch and oversized ranges.

Changes

JSON large-string test

Layer / File(s) Summary
MultiBatch range coverage
cpp/tests/large_strings/json_tests.cpp
The test documents small multi-batch and oversized ranges. It removes the half-batch and single-batch chunk sizes. The copyright notice now covers 2024–2026 and includes the NVIDIA affiliates designation.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3d61b

This updates JSON multi-batch test coverage to retain representative small and oversized ranges while removing redundant cases. No current merge-readiness risk remains.

Suggested reviewers: davidwendt

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: reducing JSON multi-batch test coverage.
Description check ✅ Passed The description directly explains the removal of redundant middle chunk sizes and the retained representative test cases.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant