Skip to content

Use rapids-python-build-retry instead of python -m build. - #24036

Open
robertmaynard wants to merge 2 commits into
NVIDIA:mainfrom
robertmaynard:fea/use_rapids-python-build-retry
Open

Use rapids-python-build-retry instead of python -m build.#24036
robertmaynard wants to merge 2 commits into
NVIDIA:mainfrom
robertmaynard:fea/use_rapids-python-build-retry

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Description

Will allow us to handle network related failures

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Will allow us to handle network related failures
@robertmaynard
robertmaynard requested a review from a team as a code owner September 8, 2026 18:34
@robertmaynard robertmaynard added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change ci labels Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 83c6bf8c-1b7d-4bd4-bda6-1f76dae37bdb

📥 Commits

Reviewing files that changed from the base of the PR and between 25b1b5a and 928a365.

📒 Files selected for processing (1)
  • ci/build_wheel.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated build telemetry to report the retry-specific build command label.

Walkthrough

The wheel build script changes the telemetry event identifier from python -m build to rapids-python-build-retry. Build arguments and execution remain unchanged.

Changes

Wheel build telemetry

Layer / File(s) Summary
Update build telemetry identifier
ci/build_wheel.sh
The telemetry record uses rapids-python-build-retry instead of python -m build. The build arguments and execution remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 032c7

Wheel-build telemetry now records rapids-python-build-retry rather than python -m build, without changing build execution or arguments. No current merge-readiness risk is identified.

Suggested reviewers: vyasr, jameslamb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing python -m build with rapids-python-build-retry.
Description check ✅ Passed The description explains that the change handles network-related failures and is directly related to the build process update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants