TEST: Focus concat input matrices - #24032
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe concatenation tests now define reusable DataFrame and input collections at module scope. Parameterized tests reference these collections and add explicit indexed, empty, overlapping, and repeated DataFrame combinations. ChangesConcatenation test parameterization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates DataFrame concat test inputs to reusable representative collections without changing production behavior. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
mroeschke
left a comment
There was a problem hiding this comment.
Some nits: OK in a follow up
| ) | ||
|
|
||
|
|
||
| _DATAFRAME_LIST_DFS = [ |
There was a problem hiding this comment.
nit: Not really fond of these _DATAFRAME_* variables defined once for 1 test. When I was refactoring tests, I preferred inlining to reduce indirection as these are relatively "frozen"
| ), | ||
| pd.DataFrame({"first_col": [], "second_col": [], "third_col": []}), | ||
| ], | ||
| pytest.param( |
There was a problem hiding this comment.
Like in your other PR, these pytest.params are superfluous and below too
|
/merge |
Description
Replace broad DataFrame concat input Cartesian products with representative input pairs. The selected cases retain distinct DataFrame/Series/list shapes, dtypes, column names, index forms, and existing-buffer behavior.
Checklist