Skip to content

TEST: Reduce redundant numerical test matrices #24019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
Sep 9, 2026
+36 −49
Merged

TEST: Reduce redundant numerical test matrices #24019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d758590
TEST: Reduce covariance correlation test matrix
vyasr Sep 6, 2026
9c52a26
TEST: Remove unused extension compilation type parameter
vyasr Sep 6, 2026
8550120
TEST: Align covariance correlation test inputs
vyasr Sep 7, 2026
e111ba5
TEST: Preserve mixed covariance correlation inputs
vyasr Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/cudf/cudf/tests/private_objects/test_extension_compilation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def func(x):


@pytest.mark.parametrize("op", arith_ops)
@pytest.mark.parametrize("ty", number_types, ids=number_ids)
def test_execute_masked_binary(op, ty):
def test_execute_masked_binary(op):
@cuda.jit(device=True)
def func(x, y):
return op(x, y)
Expand Down
82 changes: 35 additions & 47 deletions python/cudf/cudf/tests/series/methods/test_cov_corr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0


Expand All @@ -11,33 +11,46 @@
from cudf.testing import assert_eq
from cudf.testing._utils import expect_warning_if


@pytest.mark.parametrize(
"data1",
[
COV_CORR_DATA_PAIRS = [

@mroeschke mroeschke Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: This could also just be a parametrized, module scope fixture

pytest.param(
np.random.default_rng(seed=0).normal(-100, 100, 1000),
np.random.default_rng(seed=0).integers(-50, 50, 1000),
np.zeros(100),
np.repeat(np.nan, 100),
id="normal-integers",
),
pytest.param(
np.random.default_rng(seed=0).integers(-50, 50, 1000),
np.random.default_rng(seed=0).normal(-100, 100, 1000),
id="integers-normal",
),
pytest.param(np.zeros(100), np.zeros(100), id="constant"),
pytest.param(
np.repeat(np.nan, 100), np.repeat(np.nan, 100), id="all-null"
),
pytest.param(
np.array([1.123, 2.343, np.nan, 0.0]),
np.array([1.123, 2.343, np.nan, 0.0]),
id="nullable",
),
pytest.param(
pa.array([5, 10, 53, None, np.nan, None]),
np.array([1.0, 4.0, 9.0, np.nan, 16.0, 25.0]),
id="arrow",
),
pytest.param(
pd.Series([1.1, 2.32, 43.4], index=[0, 4, 3]),
np.array([], dtype="float64"),
pd.Series([43.4, 1.1, 2.32], index=[3, 0, 4]),
id="indexed-series",
),
pytest.param(np.array([], dtype="float64"), np.array([5]), id="empty"),
pytest.param(
np.array([-3]),
],
)
@pytest.mark.parametrize(
"data2",
[
np.random.default_rng(seed=0).normal(-100, 100, 1000),
np.random.default_rng(seed=0).integers(-50, 50, 1000),
np.zeros(100),
np.repeat(np.nan, 100),
np.array([1.123, 2.343, np.nan, 0.0]),
pd.Series([1.1, 2.32, 43.4], index=[0, 500, 4000]),
np.array([5]),
],
)
id="singleton",
),
]


@pytest.mark.parametrize(("data1", "data2"), COV_CORR_DATA_PAIRS)
def test_cov1d(data1, data2):
gs1 = cudf.Series(data1)
gs2 = cudf.Series(data2)
Expand All @@ -56,32 +69,7 @@ def test_cov1d(data1, data2):
np.testing.assert_approx_equal(got, expected, significant=8)


@pytest.mark.parametrize(
"data1",
[
np.random.default_rng(seed=0).normal(-100, 100, 1000),
np.random.default_rng(seed=0).integers(-50, 50, 1000),
np.zeros(100),
np.repeat(np.nan, 100),
np.array([1.123, 2.343, np.nan, 0.0]),
pa.array([5, 10, 53, None, np.nan, None]),
pd.Series([1.1032, 2.32, 43.4], index=[0, 4, 3]),
np.array([], dtype="float64"),
np.array([-3]),
],
)
@pytest.mark.parametrize(
"data2",
[
np.random.default_rng(seed=0).normal(-100, 100, 1000),
np.random.default_rng(seed=0).integers(-50, 50, 1000),
np.zeros(100),
np.repeat(np.nan, 100),
np.array([1.123, 2.343, np.nan, 0.0]),
pd.Series([1.1, 2.32, 43.4], index=[0, 500, 4000]),
np.array([5]),
],
)
@pytest.mark.parametrize(("data1", "data2"), COV_CORR_DATA_PAIRS)
def test_corr1d(data1, data2, corr_method):
if corr_method == "spearman":
# Pandas uses scipy.stats.spearmanr code-path
Expand Down
Loading