Use cuDF to count the total deleted row count for cuDF based Delta reader for deletion vectors - #15722
Open
sdrp713 wants to merge 7 commits into
Open
Use cuDF to count the total deleted row count for cuDF based Delta reader for deletion vectors#15722sdrp713 wants to merge 7 commits into
sdrp713 wants to merge 7 commits into
Conversation
Contributor
sdrp713
force-pushed
the
delta-row-cnt
branch
from
September 3, 2026 20:31
90f9680 to
c465497
Compare
gerashegalov
requested changes
Sep 4, 2026
|
|
||
| loadFutures.zip(batchExtra.perFileEntries).foreach { case (future, entry) => | ||
| try { | ||
| val gpuBitmap = future.get() |
Collaborator
There was a problem hiding this comment.
A future may succeed before it was cancelled. On this thread future.get will throw a cancelled exception and we will never get a hold of the gpuBitmap to close
Signed-off-by: Rahul Prabhu <raprabhu@nvidia.com>
sdrp713
force-pushed
the
delta-row-cnt
branch
from
September 8, 2026 17:47
316ae5d to
02c75ad
Compare
jihoonson
requested changes
Sep 8, 2026
| serializedBitmap, isRetention, rowGroupOffsets, rowGroupNumRows) | ||
| GpuSemaphore.acquireIfNecessary(TaskContext.get()) | ||
| val numDeletedRows = RmmRapidsRetryIterator.withRetryNoSplit { | ||
| DeletionVector.computeNumDeletedRows(dvInfo, maxChunkRows) |
Collaborator
There was a problem hiding this comment.
We should batch the call per partition instead of per file. We don't really need to track the deleted row count per file. We just need to know it per partition. The cudf c++ API already supports the batch computation, but we may need to modify the JNI interface.
Collaborator
Author
There was a problem hiding this comment.
Cudf PR for this here: NVIDIA/cudf#24047
Signed-off-by: Rahul Prabhu <raprabhu@nvidia.com>
Collaborator
|
Fix builds for OSS Delta shims |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14628
Related CUDF changes: NVIDIA/cudf#23978
Description
Update the cuDF based Delta deletion vector reader to use the new JNI/libcudf GPU row-count API.
The reader uses the GPU count when it needs the number of surviving rows for:
SELECT count(*).ColumnarBatch.This removes host-side deletion-vector bitmap traversal from these paths while preserving the existing row-group metadata calculation.
Testing
Performance
100 million rows, 5 million deleted rows, 2 warmups, and 10 measured runs. The
cudf-sparkand JNI changes were tested together.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance