Fix Scala 2.12 eta-expansion for verifyParquetMagic [databricks] - #15476
Open
firestarman wants to merge 1 commit into
Open
Fix Scala 2.12 eta-expansion for verifyParquetMagic [databricks]#15476firestarman wants to merge 1 commit into
firestarman wants to merge 1 commit into
Conversation
Explicitly eta-expand verifyParquetMagic when passing it to PerfIO so Scala 2.12 Databricks builds compile. Fixes NVIDIA#15475. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Contributor
Greptile SummaryThis PR fixes Scala 2.12 compilation of the Parquet footer-reading path.
Confidence Score: 5/5The PR appears safe to merge because it makes a narrowly scoped Scala 2.12 compatibility fix without changing behavior. The added underscore converts the existing Important Files Changed
Reviews (1): Last reviewed commit: "Fix Scala 2.12 eta-expansion for verifyP..." | Re-trigger Greptile |
firestarman
added a commit
to firestarman/cudf-spark
that referenced
this pull request
Jul 31, 2026
Restrict GpuIcebergWriteSummaryCommitSuite to Spark 4.1.1 where the real iceberg module is built; 412+ use iceberg-stub and lack GpuBatchAppend. Also eta-expand verifyParquetMagic for Scala 2.12 (same as NVIDIA#15476 / NVIDIA#15475). Signed-off-by: Firestarman <firestarmanllc@gmail.com>
8 tasks
Collaborator
Author
|
build |
thirtiseven
approved these changes
Jul 31, 2026
wjxiz1992
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15475.
Description
verifyParquetMagicwhen passing it toPerfIO.readParquetFooterBufferso Scala 2.12 (DB 14.3 /350db143) compiles; Scala 2.13 already auto-eta-expands and is unchanged.GpuParquetScan.scala:573withmissing argument list for method verifyParquetMagic.mvn -Dbuildver=330 -Dcuda.version=cuda13 -DskipTests -pl sql-plugin compileandvalidateon Scala 2.12.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance