[fast-ut] [reduced-it] [SkipRecovery] Restore randomized window aggregation coverage [databricks] - #15453
[fast-ut] [reduced-it] [SkipRecovery] Restore randomized window aggregation coverage [databricks]#15453wjxiz1992 wants to merge 1 commit into
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
There was a problem hiding this comment.
Pull request overview
Restores randomized coverage for test_window_aggs_for_rows in the Python integration test suite by removing a temporary seed override that was added to avoid failures related to float-to-decimal casting differences (now fixed upstream).
Changes:
- Removes the stale
@datagen_overrides(seed=0, ...)marker fromtest_window_aggs_for_rows, re-enabling normal randomized datagen behavior for this test. - Leaves the test logic, parametrization matrix, and CPU/GPU equality assertions unchanged.
Greptile SummaryRestores randomized-seed coverage for Confidence Score: 5/5The PR appears safe to merge because the marker removal allows configured seed variation without changing the tested query or comparison behavior. The integration-test harness supplies the same selected seed to both CPU and GPU data generation, and removing this non-permanent seed override introduces no unsupported execution or reproducibility failure. Important Files Changed
Reviews (1): Last reviewed commit: "test: restore randomized window aggregat..." | Re-trigger Greptile |
|
build |
JaCoCo sql-plugin line coverage: +0 lines (shim 350 vs nightly b9; the raw +2 lines were the excluded recurring
MemoryCheckerImpllocal GPU-initialization artifact)Contributes to #9682.
Summary
datagen_overrides(seed=0)marker fromtest_window_aggs_for_rows.Validation
BUILD SUCCESS; 11/11 reactor modules succeeded.2 passed, 1038 deselected, 4 warnings in 8.50s.1698940723,0,1, and42: 64/64 parameter instances passed.16 passed, 4 warnings in 26.49s.window_function_test.py:1031 passed, 5 skipped, 4 xfailed, 535 warnings in 800.29s.GpuWindow,GpuProject,GpuSort, andGpuShuffleExchangeExecBase.Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance