Fix Iceberg S3 PerfIO access with split classloaders - #15435
Open
liurenjie1024 wants to merge 6 commits into
Open
Fix Iceberg S3 PerfIO access with split classloaders#15435liurenjie1024 wants to merge 6 commits into
liurenjie1024 wants to merge 6 commits into
Conversation
Signed-off-by: Ray Liu <liurenjie2008@gmail.com>
Contributor
Greptile SummaryRestores split-classloader-safe access to Iceberg’s package-private S3 APIs.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
App[App classloader] --> Iceberg[Iceberg runtime classes]
Root[Root-loaded bridge] --> Iceberg
Shim[Shim-loaded IcebergS3InputFile] --> Root
Root --> Values[Raw S3 bucket and key]
Values --> PerfIO[S3 PerfIO range reader]
Reviews (4): Last reviewed commit: "Fix build break" | Re-trigger Greptile |
gerashegalov
left a comment
Collaborator
There was a problem hiding this comment.
This is a good PR to add a test per #14959 to prevent regressions.
Collaborator
Author
|
build |
Collaborator
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NVBUGS-6535700.
Description
#15360 reintroduced an
IllegalAccessErrorwhen Iceberg runtime jars are loaded throughspark.driver.extraClassPathandspark.executor.extraClassPath.Iceberg’s
BaseS3FileandS3URIclasses are package-private. JVM runtime-package identity includes both the package name and defining classloader, so the shim-loadedIcebergS3InputFilecannot access those classes when the Iceberg runtime is loaded by the app classloader.This change:
IcebergS3InputFileAccessbridge.BaseS3FileandS3URIinside that bridge.unshimmed-common-from-single-shim.txt.Non-S3 inputs and unsupported S3 client configurations continue to fall back to the standard Iceberg input path.
Checklists
Documentation
Testing
(
test_iceberg_parquet_read_from_uri_invalid_s3_pathand the Iceberg read/write integration suite.)Performance
Signed-off-by: Renjie Liu liurenjie2008@gmail.com