Migrate to ColumnVector mergeAndSetValidity API for substring - #15425
Open
rishic3 wants to merge 1 commit into
Open
Migrate to ColumnVector mergeAndSetValidity API for substring#15425rishic3 wants to merge 1 commit into
rishic3 wants to merge 1 commit into
Conversation
Signed-off-by: Rishi Chandra <rishic@nvidia.com>
rishic3
marked this pull request as ready for review
July 31, 2026 20:37
Collaborator
Author
|
build |
Contributor
Greptile SummaryUpdates the private GPU substring helper to accept a Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The changed private parameter matches every existing call site, and the change does not alter the substring inputs, validity-mask construction, result ownership, or resource lifecycle. Important Files Changed
Reviews (1): Last reviewed commit: "Use ColumnVector mergeAndSetValidity for..." | Re-trigger Greptile |
ttnghia
approved these changes
Jul 31, 2026
ttnghia
left a comment
Collaborator
There was a problem hiding this comment.
Approve, but we have to wait for the cudf changes to get in tomorrow before we can build this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/cudf#23249. This depends on propagation of rapidsai/cudf#23030.
Description
This prepares cudf-spark for rapidsai/cudf#23030, which adds the
ColumnVector.mergeAndSetValidityAPI and deprecates theColumnViewAPI to enforce zero-copy semantics on no-op merges.substringColumncurrently declares its string input as aColumnVieweven though every caller supplies aColumnVector. So this just changes the parameter type toColumnVectorto go through the new API. There is no change in runtime behavior. The existingtest_substringandtest_substring_columnintegration tests cover this path.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance