Reduce timezone integration tests in precommit [fast-ut] [reduced-it] [databricks] - #15419
Draft
res-life wants to merge 2 commits into
Draft
Reduce timezone integration tests in precommit [fast-ut] [reduced-it] [databricks]#15419res-life wants to merge 2 commits into
res-life wants to merge 2 commits into
Conversation
Signed-off-by: Chong Gao <chongg@nvidia.com>
Collaborator
Author
|
build |
Signed-off-by: Chong Gao <chongg@nvidia.com>
Collaborator
Author
|
build |
Collaborator
Author
|
build |
1 similar comment
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15345.
Description
Problem
Premerge currently reuses
tz_sensitive_test, the marker intended for comprehensive nightly coverage. Its parameterized tests collect 1,542 cases for each additional timezone, so the two premerge runs take approximately 10 minutes in total.Using reduced-IT selection alone would still retain 318 cases per timezone. The premerge path needs a smaller, coverage-oriented subset instead of the complete nightly matrix.
Change
Register
tz_sensitive_test_for_precommitand apply it to nine representative cases per timezone:GpuTimeZoneDBconversion pathsUpdate
spark-premerge-build.shto select the new marker. Existingtz_sensitive_testannotations and nightly selection remain unchanged.Impact
Premerge collection decreases from 1,542 to 9 cases per timezone, or from 3,084 to 18 cases across both timezone runs—a 99.4% reduction. Nightly CI continues to run the complete timezone-sensitive matrix. There is no user-facing behavior change.
Validation
-m tz_sensitive_test-m tz_sensitive_test_for_precommitAsia/ShanghaiAmerica/New_YorkChecklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance