Add skipif IS_WINDOWS for test_patterngen_seeds
#1456
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
Andy-Jost
approved these changes
Jan 12, 2026
Contributor
Andy-Jost
left a comment
Andy-Jost
left a comment
There was a problem hiding this comment.
This looks like a good change.
It seems like the root cause is that UVM is much slower on Windows than Linux "just because." If so, that's really too bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
test_patterngen_seedson Windows to restore CI performanceProblem
The
test_patterngen_seedstest runs extremely slowly on Windows platforms (up to ~945 seconds / ~15 minutes) compared to Linux (~12-15 seconds), significantly slowing down our CI and severely impeding local testing. See issue #1455 for detailed performance numbers.Solution
Add a
@pytest.mark.skipifdecorator to skip this test on Windows platforms. This restores CI and local testing speed while we work on investigating and fixing the root cause.Changes
test_patterngen_seedsincuda_core/tests/test_helpers.pycuda_core/tests/test_helpers.py::test_patterngen_seedson Windows #1455 for tracking