Fix #1336: Correct CU_POINTER_ATTRIBUTE_DEVICE_ORDINAL type #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
added
bug
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix a type mismatch for the CU_POINTER_ATTRIBUTE_DEVICE_ORDINAL attribute, which should be retrieved as a signed int rather than an unsigned int according to the CUDA documentation.
- Changed the storage type from
unsigned inttointforCU_POINTER_ATTRIBUTE_DEVICE_ORDINAL - Added test coverage for the device ordinal attribute
- Updated release notes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cuda_bindings/cuda/bindings/_lib/utils.pxd.in | Added _int field to _HelperCUpointer_attribute class |
| cuda_bindings/cuda/bindings/_lib/utils.pxi.in | Updated __cinit__ to store device ordinal in _int instead of _uint (incomplete - pyObj not updated) |
| cuda_bindings/tests/test_cuda.py | Added test for device ordinal attribute retrieval |
| cuda_bindings/docs/source/release/13.1.X-notes.rst | Documented the bugfix in release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
rparolin
approved these changes
Jan 9, 2026
Collaborator
|
@greptileai, please review |
kkraus14
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs for
CU_POINTER_ATTRIBUTE_DEVICE_ORDINALsay:This attribute type was erroneously being converted to an unsigned int. This simply fixes that and adds a test.
Checklist