Fix exception clauses in Buffer.fill helpers #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use non-void return types with explicit exception clauses for Cython helpers that may raise via HANDLE_RETURN.
Contributor
Contributor
Author
|
/ok to test e9dca3e |
Contributor
Author
|
/ok to test 881fba8 |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Dec 16, 2025
leofang
added
enhancement
Contributor
Author
|
/ok to test 0a07bad |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Buffer.fillto use non-voidreturn types with explicit exception clauses, avoiding Cython 3 warnings while preserving behavior.Test plan
pre-commit run --all-files