Skip to content

Conversation

@salmanmkc
Copy link
Contributor

Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/checkout v4 v6 Release cleanup-pr-previews.yml
actions/github-script v7 v8 Release build-wheel.yml

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

Why this matters

  • Node 20 EOL: April 2026
  • Node 24 default: March 4th, 2026
  • Action: Update to latest action versions that support Node 24

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@salmanmkc salmanmkc force-pushed the upgrade-github-actions-node24 branch from 15d3ed3 to 4d6d1c3 Compare December 16, 2025 12:13
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But shouldn't we be pinning this to a hash as we do for most of our other actions for security? I'm approving this anyway because it doesn't make things any worse in that regard, but maybe we should come back and make sure all of our actions are specified with hashes (which is something I thought our linting did, but maybe not...)

@NVIDIA NVIDIA deleted a comment from copy-pr-bot bot Dec 16, 2025
@mdboom
Copy link
Contributor

mdboom commented Dec 16, 2025

/ok to test 4d6d1c3

@github-actions

This comment has been minimized.

Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
@salmanmkc salmanmkc force-pushed the upgrade-github-actions-node24 branch from 4d6d1c3 to e684597 Compare December 16, 2025 15:06
@mdboom
Copy link
Contributor

mdboom commented Dec 16, 2025

/ok to test e684597

@mdboom mdboom enabled auto-merge (squash) December 16, 2025 16:32
@mdboom mdboom merged commit 64cdc1b into NVIDIA:main Dec 16, 2025
57 of 62 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang added the CI/CD CI/CD infrastructure label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants