Strip zero-width or unprintable unicode characters#9564
Open
Jacobfaib wants to merge 5 commits into
Open
Conversation
bdice
reviewed
Jun 23, 2026
|
|
||
| # Perl character class assembled from column 1 of the ranges table. | ||
| BAD_CLASS="[$(ranges | cut -f1 | tr -d '\n')]" | ||
| PERL="${PERL:-perl}" |
Contributor
There was a problem hiding this comment.
Is it safe to assume that all developer systems have perl installed? Should there be a fallback (like skipping the check) if perl isn't installed?
Contributor
Author
There was a problem hiding this comment.
This is mostly if you have multiple perls installed (e.g. one from system and one from package manager). I seriously doubt this would be needed often, but I always like to provide such escape hatches for the "main" driver utils of scripts so that users can just do e.g.
PYTHON=/my/python AWK=/my/awk PERL=/my/perl script.bash
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d26b98bc-e2d9-4690-9713-285bbe5df56a
📒 Files selected for processing (20)
.github/actions/workflow-build/build-workflow.py.pre-commit-config.yamlAGENTS.mdci/util/pre-commit/strip_unprintable.bashci/windows/build_common.psm1ci/windows/run_cpu_bisect.ps1ci/windows/run_cpu_target.ps1ci/windows/run_gpu_bisect.ps1ci/windows/run_gpu_target.ps1cudax/include/cuda/experimental/__stf/internal/acquire_release.cuhcudax/test/stf/examples/05-stencil-no-copy.cucudax/test/stf/examples/05-stencil.cucudax/test/stf/stencil/stencil-1D.cudocs/cudax/stf.rstlibcudacxx/include/cuda/std/__iterator/iterator_traits.hlibcudacxx/include/cuda/std/__simd/concepts.hlibcudacxx/include/cuda/std/__simd/creation.hlibcudacxx/include/cuda/std/__simd/permute.hlibcudacxx/include/cuda/std/__tuple_dir/tuple_constraints.hlibcudacxx/test/libcudacxx/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp
Jacobfaib
force-pushed
the
jacobf/2026-06-23/unprintable-unicode
branch
from
117a81f to
c7d88e3
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1794435e-6fef-4d8b-8124-bef7b1f740d9
📒 Files selected for processing (36)
.github/actions/workflow-build/build-workflow.py.pre-commit-config.yamlAGENTS.mdci/util/pre-commit/strip_unprintable.bashci/windows/build_common.psm1ci/windows/build_cuda_cccl_python.ps1ci/windows/run_cpu_bisect.ps1ci/windows/run_cpu_target.ps1ci/windows/run_gpu_bisect.ps1ci/windows/run_gpu_target.ps1cudax/include/cuda/experimental/__stf/internal/acquire_release.cuhcudax/test/stf/examples/05-stencil-no-copy.cucudax/test/stf/examples/05-stencil.cucudax/test/stf/stencil/stencil-1D.cudocs/cub/tuning.rstdocs/cudax/stf.rstdocs/libcudacxx/extended_api/memory_model.rstdocs/libcudacxx/extended_api/synchronization_primitives/atomic_ref.rstdocs/libcudacxx/extended_api/synchronization_primitives/barrier/barrier_native_handle.rstdocs/libcudacxx/index.rstlibcudacxx/include/cuda/std/__iterator/iterator_traits.hlibcudacxx/include/cuda/std/__simd/concepts.hlibcudacxx/include/cuda/std/__simd/creation.hlibcudacxx/include/cuda/std/__simd/permute.hlibcudacxx/include/cuda/std/__tuple_dir/tuple_constraints.hlibcudacxx/test/TODO.TXTlibcudacxx/test/libcudacxx/libcxx/iterators/compressed_movable_box/assign.copy.pass.cpplibcudacxx/test/libcudacxx/std/algorithms/alg.nonmodifying/alg.for_each/ranges.for_each.pass.cpplibcudacxx/test/libcudacxx/std/algorithms/alg.nonmodifying/alg.for_each/ranges.for_each_n.pass.cpplibcudacxx/test/libcudacxx/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpplibcudacxx/test/libcudacxx/std/utilities/const.wrap.class/call.pass.cpplibcudacxx/test/libcudacxx/std/utilities/const.wrap.class/convert.pass.cpplibcudacxx/test/libcudacxx/std/utilities/const.wrap.class/cw.pass.cpplibcudacxx/test/libcudacxx/std/utilities/const.wrap.class/unary_ops.pass.cpplibcudacxx/test/libcudacxx/std/utilities/time/time.clock/time.clock.system/local_time.types.pass.cpplibcudacxx/test/libcudacxx/std/utilities/time/time.clock/time.clock.system/sys.time.types.pass.cpp
✅ Files skipped from review due to trivial changes (31)
- ci/windows/run_cpu_target.ps1
- ci/windows/run_gpu_bisect.ps1
- libcudacxx/include/cuda/std/__simd/concepts.h
- docs/libcudacxx/extended_api/synchronization_primitives/barrier/barrier_native_handle.rst
- libcudacxx/test/libcudacxx/std/utilities/time/time.clock/time.clock.system/local_time.types.pass.cpp
- ci/windows/build_common.psm1
- libcudacxx/test/libcudacxx/std/utilities/const.wrap.class/unary_ops.pass.cpp
- libcudacxx/test/libcudacxx/std/utilities/const.wrap.class/call.pass.cpp
- docs/libcudacxx/index.rst
- libcudacxx/test/libcudacxx/libcxx/iterators/compressed_movable_box/assign.copy.pass.cpp
- libcudacxx/test/libcudacxx/std/utilities/const.wrap.class/cw.pass.cpp
- libcudacxx/test/TODO.TXT
- ci/windows/run_cpu_bisect.ps1
- cudax/test/stf/examples/05-stencil-no-copy.cu
- AGENTS.md
- libcudacxx/include/cuda/std/__simd/permute.h
- libcudacxx/test/libcudacxx/std/utilities/const.wrap.class/convert.pass.cpp
- docs/cub/tuning.rst
- docs/libcudacxx/extended_api/memory_model.rst
- cudax/test/stf/stencil/stencil-1D.cu
- libcudacxx/test/libcudacxx/std/utilities/time/time.clock/time.clock.system/sys.time.types.pass.cpp
- docs/libcudacxx/extended_api/synchronization_primitives/atomic_ref.rst
- cudax/include/cuda/experimental/__stf/internal/acquire_release.cuh
- libcudacxx/include/cuda/std/__iterator/iterator_traits.h
- libcudacxx/include/cuda/std/__simd/creation.h
- ci/windows/run_gpu_target.ps1
- libcudacxx/include/cuda/std/__tuple_dir/tuple_constraints.h
- .github/actions/workflow-build/build-workflow.py
- cudax/test/stf/examples/05-stencil.cu
- libcudacxx/test/libcudacxx/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp
- docs/cudax/stf.rst
🚧 Files skipped from review as they are similar to previous changes (1)
- ci/util/pre-commit/strip_unprintable.bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove zero-width unicode characters (otherwise known as inutterable or voldemort characters). These glyphs are invisible to a reader but may be rendered strangely in certain editors or text environments.
Ideally I'd like to just convert everything to ASCII, but CUB has some lovely text-art using unicode that doesn't translate so well.
Checklist