Skip to content

Test: Validate CI workflow changes from PR #163#174

Open
brycelelbach wants to merge 2 commits intomainfrom
test/ci-workflow-validation
Open

Test: Validate CI workflow changes from PR #163#174
brycelelbach wants to merge 2 commits intomainfrom
test/ci-workflow-validation

Conversation

@brycelelbach
Copy link
Copy Markdown
Collaborator

Summary

Temporary PR to validate the CI workflow changes landed in PR #163. This branch intentionally triggers all 5 CI checks to verify:

  1. YAML check -- bad.yaml with indentation errors and duplicate keys
  2. Link check -- bad-link.md with a broken GitHub URL
  3. Notebook format check -- bad-notebook.ipynb with non-canonical format, outputs, and execution counts
  4. Git LFS check -- not-lfs-tracked.png added without LFS tracking
  5. Git signature check -- One commit is deliberately unsigned

What to verify

  • All 5 test workflows trigger on the push event (not pull_request)
  • All 5 test workflows fail as expected
  • All 5 PR comment workflows fire and post comments with correct formatting
  • PR comments include collapsible <details> blocks with error output
  • Concurrency groups work (push again to verify superseded runs are cancelled)

Cleanup

Delete this PR and branch once validation is complete.

Add test files that deliberately trigger all 5 CI checks:
- bad.yaml: indentation and duplicate key errors (yamllint)
- bad-link.md: broken URL (lychee link checker)
- bad-notebook.ipynb: non-canonical format with outputs (notebook format)
- not-lfs-tracked.png: PNG added without LFS (git-lfs check)
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 28, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown
Contributor

❌ YAML Check Failed

🔗 View workflow run logs

YAML lint errors
./test/ci-validation/bad.yaml:2:13: [error] syntax error: mapping values are not allowed here (syntax)

How to fix:

pip install yamllint
yamllint -d "{rules: {line-length: disable}}" .

📚 yamllint documentation

@github-actions
Copy link
Copy Markdown
Contributor

❌ Git Signature Check Failed

🔗 View workflow run logs

Found 1 unsigned commit(s):

Unsigned commits
  • 4ae7bff: Test: Add unsigned commit to trigger signature check. (unsigned)

How to fix:

  1. Configure commit signing (if not already done):

    # For GPG signing
    git config --global commit.gpgsign true
    
    # Or for SSH signing (Git 2.34+)
    git config --global gpg.format ssh
    git config --global user.signingkey ~/.ssh/id_ed25519.pub
  2. Re-sign your commits:

    git rebase -i origin/main --exec "git commit --amend --no-edit -S"
    git push --force-with-lease

📚 GitHub documentation on signing commits

@github-actions
Copy link
Copy Markdown
Contributor

❌ Link Check Failed

🔗 View workflow run logs

Broken links found by Lychee

Summary

Status Count
🔍 Total 1089
✅ Successful 1012
⏳ Timeouts 0
🔀 Redirected 42
👻 Excluded 28
❓ Unknown 0
🚫 Errors 1
⛔ Unsupported 6

Errors per input

Errors in ./test/ci-validation/bad-link.md

Redirects per input

Redirects in ./Accelerated_Python_User_Guide/notebooks/Chapter_01_GPU_Computing_Basics.md

Redirects in ./Accelerated_Python_User_Guide/notebooks/Chapter_10_Developer_Tools.md

Redirects in ./Accelerated_Python_User_Guide/notebooks/Chapter_11_Distributed_Computing_cuPyNumeric.md

Redirects in ./Accelerated_Python_User_Guide/notebooks/Chapter_12.1_IsingModel_In_Warp.md

Redirects in ./CODE_OF_CONDUCT.md

Redirects in ./CONTRIBUTING.md

Redirects in ./docs/brev_launchable_architecture.md

Redirects in ./README.md

Redirects in ./resources/README.md

Redirects in ./SECURITY.md

Redirects in ./tutorials/accelerated-python/notebooks/distributed/61__dask.md

Redirects in ./tutorials/accelerated-python/notebooks/fundamentals/00__what_are_gpus.md

Redirects in ./tutorials/accelerated-python/notebooks/syllabi/cuda_python__cupy_cudf_cccl_kernels__8_hours.md

Redirects in ./tutorials/accelerated-python/notebooks/syllabi/pyhpc__numpy_cupy_mpi4py__4_hours.md

Redirects in ./tutorials/gpu-deployment/gpu-deployment-from-scratch.md

Redirects in ./tutorials/nvmath-python/README.md

Redirects in ./tutorials/stdpar/notebooks/cpp/lab1_daxpy/daxpy.md

Redirects in ./tutorials/stdpar/notebooks/cpp/lab1_select/select.md

Redirects in ./tutorials/stdpar/notebooks/cpp/lab2_heat/heat.md

Full Github Actions output

Common fixes:

  1. Typo in URL - Check for spelling mistakes in the link
  2. Outdated link - The page may have moved or been deleted
  3. Relative path issue - Ensure relative links use the correct path
  4. External site down - If the external site is temporarily down, you can add it to brev/.lycheeignore

To test links locally:

./brev/test-links.bash .

📚 Lychee documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant