perf(rtx): precompute float light-pick delta, drop kernel f64 diff#347
Merged
jeffamstutz merged 1 commit intoJul 17, 2026
Merged
Conversation
Store each light slot's pick mass (power_i/total) as a standalone float host-side and read it directly, instead of differencing adjacent double lightPickCdf entries per pick in the kernels — the standalone float represents a dim light's sub-epsilon mass that the float CDF diff would drop, so the kernel f64 arithmetic goes away with strictly more accurate mass. Perf-neutral.
jeffamstutz
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store each light slot's pick probability as a standalone float host-side and read it directly, instead of differencing adjacent double lightPickCdf entries per pick in the kernels.
Keep precision while decreasing double precision usage in the kernel.