fix(rtx): robust analytic primitive intersection & shading#334
Merged
Conversation
Recondition cone/cylinder/sphere intersection (intersectPrimitives.h) to better handle precision issues and corner cases. Adds an fp64 oracle, property/metamorphic sweeps, and API tests for the failure modes. API sweeps cover sphere far/tiny/huge object coords, transform resilience, and the zero-radius degenerate; the oracle asserts a cone wall/cap rim never over-counts crossings.
tarcila
changed the title
Collaborator
Author
|
FYI @stukowski This should be helping the precision issues you ran into. |
jeffamstutz
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recondition cone/cylinder/sphere intersection (intersectPrimitives.h) to better handle precision issues and
corner cases.
Adds an fp64 oracle, property/metamorphic sweeps, and API tests for the failure modes. API sweeps cover sphere
far/tiny/huge object coords, transform resilience, and the zero-radius degenerate; the oracle asserts a cone
wall/cap rim never over-counts crossings.