Use <cmath> instead of <math.h> in context attention FMHA headers#120
Open
whitesscott wants to merge 1 commit into
Open
Use <cmath> instead of <math.h> in context attention FMHA headers#120whitesscott wants to merge 1 commit into
whitesscott wants to merge 1 commit into
Conversation
This replaces C-style <math.h> includes in the context attention FMHA code with the C++ <cmath> header. Including <math.h> from a public header is fragile in CUDA/TensorRT builds, especially on Jetson/Thor where CUDA include paths are active and the C math header may resolve through CUDA wrapper headers. Using <cmath> keeps the code consistent with C++ compilation and avoids leaking C math-header behavior into translation units that include fmhaParams_v2.h. No runtime behavior change intended. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<math.h>includes in the context attention FMHA code with the C++<cmath>header (contextFMHARunner.cpp,fmhaParams_v2.h).<math.h>to resolve through CUDA wrapper headers when transitively included fromfmhaParams_v2.h.<cmath>avoids that C-header leakage.Test plan
cpp/succeeds on Jetson/Thor (CUDA 13.2) without the prior<math.h>resolution error.<math.h>(e.g.M_PI) — none observed in the two touched files.🤖 Generated with Claude Code