Fix quality scoring with CommonMark structural parsing - #53
Merged
chrisknvidia merged 6 commits intoAug 21, 2026
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
rng1995
reviewed
Aug 20, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
Focused review of the CommonMark link-normalization changes found one scoring edge case; the parser/quality-score regression suite otherwise passed locally.
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
commented
Aug 21, 2026
chrisknvidia
left a comment
Collaborator
Author
There was a problem hiding this comment.
Second-pass review found two reproducible correctness issues in the broader parser change. The original URL-edge-whitespace fix is correct and its thread is resolved.
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
…owup Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
marked this pull request as ready for review
August 21, 2026 12:01
chrisknvidia
deleted the
fix/christopherk/quality-score-commonmark-followup
branch
August 21, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markdown-it-pyCommonMark token parsing.Why
This is a follow-up to #45 and its post-merge review. The previous implementation used regexes to infer author intent and reimplemented substantial Markdown syntax. Those approaches were difficult to maintain and could produce false score changes for valid prose or Markdown.
Deterministic Tier 1 scoring now relies on unambiguous lexical boundaries and parsed structural evidence. Semantic documentation quality remains the responsibility of
rubric-eval, while observed execution behavior remains a Tier 3 concern.Validation
ruff check ., changed-file formatting,uv lock --check, OSS source/archive scans, andgit diff --checkpassed.One bridge test was intentionally excluded from both full-suite runs because an unrelated existing process owns port 18080. The untouched
origin/mainbaseline reproduces the same environmental failure; the other three deselections are the repository defaults.