fix(scripts): redirect all operational log messages to stderr#1072
fix(scripts): redirect all operational log messages to stderr#1072latenighthackathon wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
All echo statements in nemoclaw-start.sh wrote to stdout, which caused [gateway] and [SECURITY] log messages to leak into application output. This is visible when the Telegram bridge captures stdout — setup messages like "Running as non-root" get prepended to every chat response. Redirect all operational and security log messages to stderr so only actual command output (from exec'd processes) appears on stdout. Closes NVIDIA#1064
2be4ba9 to
4194688
Compare
Summary
All echo statements in nemoclaw-start.sh wrote to stdout, causing gateway and security log messages to leak into application output. The Telegram bridge captures stdout, so setup messages were prepended to every chat response.
Related Issue
Closes #1064
Changes
Type of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)Checklist
General
Code Changes
Summary by CodeRabbit