Skip to content

fix tests (failed bcause of certs, and fixed jwer version)#134

Merged
Jorjeous merged 11 commits into
mainfrom
update_certifi_for_COORAL
Jul 2, 2025
Merged

fix tests (failed bcause of certs, and fixed jwer version)#134
Jorjeous merged 11 commits into
mainfrom
update_certifi_for_COORAL

Conversation

@Jorjeous

Copy link
Copy Markdown
Collaborator
  1. jiwer latest update depricated method, for now soft-fixing it's version to avoid it
  2. CORAAL have somesing broken in it's https certificates (probably they outdated and not refreshed), so allowing download of their data by adding cert manually

Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
@Jorjeous Jorjeous added the fix Fixing something label Jun 30, 2025

@karpnv karpnv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread .github/workflows/tests.yml Outdated
pip install nemo-toolkit[asr,nlp]==1.23.0
pip install nemo_text_processing
pip install -r requirements/huggingface.txt
pip install certifi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi George, let's have comments for these changes

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок

Jorjeous added 10 commits July 2, 2025 06:33
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
@Jorjeous Jorjeous merged commit 828a750 into main Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixing something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants