Validate chapter duration in HiFiTTS-2 download#129
Merged
Conversation
Signed-off-by: Ryan <rlangman@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Collaborator
|
LGTM |
Jorjeous
approved these changes
Jun 17, 2025
Jorjeous
left a comment
Jorjeous
left a comment
Collaborator
There was a problem hiding this comment.
1)HIFITTS part looks good
2)Added installation in dockerfile to prevent cascade errors
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue when downloading HiFiTTS-2 in which some audiobook chapters have been updated/edited since the dataset was first created, causing the utterances in the chapter to be misaligned.
To fix this, each chapter has had its full duration added to the dataset metadata. If the downloaded chapter file has a duration different than the original duration when the dataset is created, it will be marked as an error and removed from the dataset.
Also after adding this, and finding there are a few other random errors that can happen during download (e.g. http.client.RemoteDisconnected), I removed the "error_code" from the output which is unique to the HTTPError.