Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
cd3c368
Update PDF blueprint architecture diagram
kheiss-uwzoo Feb 19, 2026
70b5a80
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Feb 24, 2026
7f0248c
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Feb 25, 2026
0dd5f1b
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Feb 26, 2026
dea2770
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Feb 27, 2026
3ff2f1f
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Feb 27, 2026
a886244
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 2, 2026
b44f7ad
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 2, 2026
addf637
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 2, 2026
5900322
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 4, 2026
d12df70
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 4, 2026
67e674b
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 10, 2026
83c3c42
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 10, 2026
371d883
Introduce release branch 26.03 with version 26.3.0-RC1
jdye64 Mar 11, 2026
4af706f
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 11, 2026
a5812fa
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 11, 2026
6ecb070
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 11, 2026
72173fc
Release prep: Update version to 26.03.0-RC1 (#1574)
jdye64 Mar 11, 2026
852910c
(retriever) Add .split() for text chunking by token count (#1547) (#1…
edknv Mar 11, 2026
64c694b
(retriever) add documentation for image file support (#1571) (#1577)
edknv Mar 11, 2026
d38abb2
[26.03] Refactor get_*_model_name to avoid caching fallback model nam…
charlesbluca Mar 11, 2026
fbd2e28
[26.03] (helm) More nemotron rebranding (#1581)
charlesbluca Mar 11, 2026
ba92f69
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 11, 2026
1835ba7
Add source_id column back to lancedb
jdye64 Mar 12, 2026
db03ed7
upmerge
jperez999 Mar 11, 2026
5cbf38e
fix reranker in inproc (#1588)
jperez999 Mar 12, 2026
6459e60
Add source_id to output columns
jdye64 Mar 12, 2026
ed95c44
fix in process extract to handle txt (#1589)
jperez999 Mar 12, 2026
9568b50
Release prep: 26.03.0-RC2 (#1591)
jdye64 Mar 12, 2026
4a8301e
Increase default Redis TTL from 1-2h to 48h to prevent job expiry dur…
jioffe502 Mar 11, 2026
4f4e512
Add Helm RTX PRO 4500 override, extend obj-det warmup batch size over…
charlesbluca Mar 12, 2026
41d2b07
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 12, 2026
be53306
(retriever) update nemotron_parse extraction method (#1599) (#1604)
edknv Mar 12, 2026
491aed0
(retriever) auto-route image files in .extract() for both inprocess a…
edknv Mar 12, 2026
82088d7
Dump libfreetype source in release container (#1600) (#1606)
charlesbluca Mar 12, 2026
10c7435
Unit test failure fixes (#1607)
jdye64 Mar 12, 2026
11662db
Fix markdown outputs for batch and inprocess. (#1601)
jioffe502 Mar 12, 2026
02c2dcd
(retriever) update pre/post-processing for improved recall (#1596) (#…
edknv Mar 12, 2026
f55a733
Remove get_hf_revision logic from code not inside the nemo_retriever …
jdye64 Mar 13, 2026
c00b6bf
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Mar 13, 2026
83a936c
Added air gap instructions to helm file (#1616)
kheiss-uwzoo Mar 13, 2026
4d9ce5f
fix for network call reranking (#1619)
jperez999 Mar 13, 2026
0a60c1a
Release prep: Update versions to 26.3.0-RC4 (#1620)
jdye64 Mar 13, 2026
86cda76
Updated RNs to show forthcoming changes (#1623)
kheiss-uwzoo Mar 13, 2026
e5e3b36
update rns (#1624)
kheiss-uwzoo Mar 13, 2026
ce8133d
Fix score (#1627)
jperez999 Mar 14, 2026
8908e21
rm assert on rerank and readme (#1628)
jperez999 Mar 14, 2026
7d112c3
cherry-pick 15b2bc05681599329276e46e83edfa0f15bb4318 from main
randerzander Mar 16, 2026
823775d
Release prep: update version references to 26.3.0 (#1638)
jdye64 Mar 16, 2026
7b54385
26.03 RNs (#1641)
kheiss-uwzoo Mar 17, 2026
b7be9ba
update quickstart library mode (#1642)
kheiss-uwzoo Mar 18, 2026
1c6ec79
update release version from 26.1.3 to 26.3.0 on Release Notes (#1643)
kheiss-uwzoo Mar 18, 2026
cfd0b72
Kheiss/bullets (#1644)
kheiss-uwzoo Mar 18, 2026
818de0a
Update README.md
kheiss-uwzoo Mar 18, 2026
671d78a
Updating & simplifying main README (#1647) (#1650)
jperez999 Mar 18, 2026
85168e2
updates to release notes to fix bullets and doc link (#1651)
kheiss-uwzoo Mar 18, 2026
4075ae9
Kheiss/5970976 (#1652)
kheiss-uwzoo Mar 18, 2026
ebb1253
Kheiss/5966534 (#1653)
kheiss-uwzoo Mar 18, 2026
924a18e
Kheiss/5970976 - change location of air gap documentation (#1656)
kheiss-uwzoo Mar 18, 2026
4129d5b
Revert doc naming changes
jdye64 Mar 19, 2026
22d58bf
Confirmed product naming of NeMo Retriever Library in files and code …
kheiss-uwzoo Mar 19, 2026
17e0148
update helm file (#1679)
kheiss-uwzoo Mar 20, 2026
3d4fdae
updated quickstart to current version following reversion (#1683)
kheiss-uwzoo Mar 23, 2026
b1f56bb
Kheiss/quickstart lib mode update (#1682)
kheiss-uwzoo Mar 23, 2026
19e77e1
Update RNs to current version (#1687)
kheiss-uwzoo Mar 23, 2026
0e0bebc
Kheiss/update quickstart (#1688)
kheiss-uwzoo Mar 23, 2026
77cb39a
update reference diagram for overview (#1689)
kheiss-uwzoo Mar 23, 2026
56c2c51
fixed reference information about name change from nv-ingest to NeMo …
kheiss-uwzoo Mar 23, 2026
6758c17
changed opening note to NVIDIA Ingest (nv-ingest) has been renamed N…
kheiss-uwzoo Mar 23, 2026
3db9a49
remove duplicate caption() section with wrong parameters (NVBug 60006…
kheiss-uwzoo Mar 23, 2026
f0f9e97
Kheiss/6000618 (#1694)
kheiss-uwzoo Mar 23, 2026
cf22e8c
fix syntax (#1696)
kheiss-uwzoo Mar 23, 2026
cc33bea
Kheiss/6000353 - update links to Helm chart (#1697)
kheiss-uwzoo Mar 23, 2026
fa30ff8
Document RTX PRO 4500 Blackwell (GB203) in hardware support matrix 59…
kheiss-uwzoo Mar 23, 2026
726340c
fixed the contributing.md (#1706)
sosahi Mar 24, 2026
ad96fc9
add contributing.md back to repository (#1709)
kheiss-uwzoo Mar 24, 2026
bcaf8f3
Kheiss/6000353 - update links to older RNs (#1712)
kheiss-uwzoo Mar 24, 2026
486a0de
Kheiss/5966538 - document Python 3.12+ as a prerequisite for NeMo Ret…
kheiss-uwzoo Mar 24, 2026
f07e881
Aligns NeMo Retriever Library extraction docs with the current defaul…
kheiss-uwzoo Mar 25, 2026
f6e5869
Align nemotron-parse overview with three methods (NVBug 5965574); (#1…
kheiss-uwzoo Mar 25, 2026
998f26b
Kheiss/updates0325 (#1734)
kheiss-uwzoo Mar 25, 2026
a6ef79a
removed duplication of the word NVIDIA (#1736)
kheiss-uwzoo Mar 26, 2026
a07ac1d
removed reference to zipking (#1737)
kheiss-uwzoo Mar 26, 2026
fd1353a
Fixed bug 5966370 (#1744)
kheiss-uwzoo Mar 27, 2026
c63daab
Align production GPU examples with support matrix (NVBug 5965601) (#…
kheiss-uwzoo Mar 30, 2026
9dc88b5
Kheiss/5966722 (#1743)
kheiss-uwzoo Mar 30, 2026
6c3c2a6
Updated files per bugs 5970369, 5966307, and 5966925 (#1740)
kheiss-uwzoo Mar 30, 2026
53262b4
Align VLM caption model and MinIO defaults with runtime (#1739)
kheiss-uwzoo Mar 30, 2026
1a91164
added licensing info to documentation (#1750)
kheiss-uwzoo Mar 30, 2026
b5d7b96
updated quickstart guide file per 5966239 (#1751)
kheiss-uwzoo Mar 30, 2026
4744677
update support matrix to add footnotes
kheiss-uwzoo Mar 30, 2026
e8759e2
update support matrix to add footnotes (#1752)
kheiss-uwzoo Mar 30, 2026
f39912f
Merge remote-tracking branch 'upstream/26.03' into 26.03
kheiss-uwzoo Mar 30, 2026
29f787b
Kheiss/5966297update (#1758)
kheiss-uwzoo Mar 31, 2026
c5e1c22
Align VLM caption model, fix V2 ingest() example, document run_pipel…
kheiss-uwzoo Mar 31, 2026
7461ce4
Merge remote-tracking branch 'upstream/26.03' into 26.03
kheiss-uwzoo Mar 31, 2026
d56a8cb
Merge branch '26.03' into main
kheiss-uwzoo Apr 2, 2026
3e80634
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Apr 2, 2026
7f73df3
Merge remote-tracking branch 'upstream/main'
kheiss-uwzoo Apr 14, 2026
f3db922
ci(docs): fail on container exit and print logs in docs workflows
kheiss-uwzoo Apr 14, 2026
b705e0d
Merge branch 'main' into kheiss/041426updates
kheiss-uwzoo Apr 14, 2026
530ce6d
Docs CI failed because the docs Docker image never included nemo_retr…
kheiss-uwzoo Apr 14, 2026
e861f8a
Merge branch 'main' into kheiss/041426updates
kheiss-uwzoo Apr 14, 2026
e4328b4
ci(docs): checkout triggering ref for manual doc workflow runs
kheiss-uwzoo Apr 14, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/build-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
build:
runs-on: linux-large-disk
steps:
# Use the ref that triggered the workflow (e.g. branch chosen for workflow_dispatch).
# Do not pin ref: main here — that forced manual runs to build from main while testing other branches.
- name: Checkout code
uses: actions/checkout@v4
with:
ref: main

- name: Setup Pages
uses: actions/configure-pages@v5
Expand All @@ -46,8 +46,16 @@ jobs:
CONTAINER_ID=$(docker run -d nv-ingest-docs:latest)
echo "CONTAINER_ID=$CONTAINER_ID" >> $GITHUB_ENV

# docker wait reports the container exit code but does not fail the step if it is non-zero.
# Emit logs here and exit with the same code so CI fails on make docs and the log shows why.
- name: Wait for the docs generation to complete in the container
run: docker wait $CONTAINER_ID
run: |
EXIT_CODE=$(docker wait "$CONTAINER_ID")
echo "Container exit code: ${EXIT_CODE}"
echo "--- Container logs (make docs output) ---"
docker logs "$CONTAINER_ID"
echo "--- End container logs ---"
exit "${EXIT_CODE}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Container not cleaned up on build failure

When EXIT_CODE is non-zero, this step fails and GitHub Actions skips the subsequent docker rm $CONTAINER_ID step (line 64), leaving an orphaned container on the self-hosted linux-large-disk runner. Before this change, docker wait always exited 0, so cleanup always ran. The same issue exists in docs-deploy.yml line 56. Add if: always() to the cleanup step to ensure it runs even on failure:

      - name: Stop and remove the container
        if: always()
        run: docker rm $CONTAINER_ID
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/build-docs.yml
Line: 58

Comment:
**Container not cleaned up on build failure**

When `EXIT_CODE` is non-zero, this step fails and GitHub Actions skips the subsequent `docker rm $CONTAINER_ID` step (line 64), leaving an orphaned container on the self-hosted `linux-large-disk` runner. Before this change, `docker wait` always exited 0, so cleanup always ran. The same issue exists in `docs-deploy.yml` line 56. Add `if: always()` to the cleanup step to ensure it runs even on failure:

```yaml
      - name: Stop and remove the container
        if: always()
        run: docker rm $CONTAINER_ID
```

How can I resolve this? If you propose a fix, please make it concise.


- name: Copy generated docs site from the container
run: docker cp $CONTAINER_ID:/workspace/docs/site ./generated-site
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/docs-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
name: Build Documentation
runs-on: linux-large-disk
steps:
# Use the ref that triggered the workflow (e.g. branch chosen for workflow_dispatch).
# Do not pin ref: main here — that forced manual runs to build from main while testing other branches.
- name: Checkout code
uses: actions/checkout@v4
with:
ref: main

- name: Setup Pages
uses: actions/configure-pages@v5
Expand All @@ -44,8 +44,16 @@ jobs:
CONTAINER_ID=$(docker run -d nv-ingest-docs:latest)
echo "CONTAINER_ID=$CONTAINER_ID" >> $GITHUB_ENV

# docker wait reports the container exit code but does not fail the step if it is non-zero.
# Emit logs here and exit with the same code so CI fails on make docs and the log shows why.
- name: Wait for documentation generation
run: docker wait $CONTAINER_ID
run: |
EXIT_CODE=$(docker wait "$CONTAINER_ID")
echo "Container exit code: ${EXIT_CODE}"
echo "--- Container logs (make docs output) ---"
docker logs "$CONTAINER_ID"
echo "--- End container logs ---"
exit "${EXIT_CODE}"

- name: Copy generated docs from container
run: docker cp $CONTAINER_ID:/workspace/docs/site ./generated-site
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ COPY docs docs
COPY src src
COPY api api
COPY client client
COPY nemo_retriever nemo_retriever

RUN --mount=type=cache,target=/root/.cache/uv \
uv pip install -r ./docs/requirements.txt
Expand Down
Loading