Skip to content

Fix typo and improve test infrastructure robustness#1797

Open
RobbiWillm wants to merge 2 commits intoNVIDIA:mainfrom
RobbiWillm:docs/fix-readme-typo
Open

Fix typo and improve test infrastructure robustness#1797
RobbiWillm wants to merge 2 commits intoNVIDIA:mainfrom
RobbiWillm:docs/fix-readme-typo

Conversation

@RobbiWillm
Copy link
Copy Markdown

@RobbiWillm RobbiWillm commented Apr 5, 2026

Summary

This PR makes two small improvements:

  1. Documentation: Fixes in README.md ("computaiton" → "computation")
  2. Test Infrastructure: Adds input validation to _wait_for_port function in integration test conftest.py

Changes

README.md

  • Fixed spelling error on line 21

tests/integration/conftest.py

  • Added validation for negative timeout values in _wait_for_port helper
  • Added validation for negative interval values
  • This prevents silent failures from misconfigured test timeouts

Testing

The conftest.py change improves test reliability by catching configuration errors early rather than hanging or producing confusing timeout errors.


Note: Changes to test infrastructure may benefit from running integration tests to verify no regressions.

- Fix 'computaiton' typo in README.md

- Add input validation to _wait_for_port in tests/integration/conftest.py to prevent invalid timeout/interval values

This improves test reliability by catching configuration errors early.

Signed-off-by: RobbiWillm <23glories.novas@icloud.com>
@RobbiWillm RobbiWillm requested review from a team as code owners April 5, 2026 11:35
@RobbiWillm RobbiWillm requested a review from jperez999 April 5, 2026 11:35
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 5, 2026

Greptile Summary

This PR makes two minor improvements: a spelling fix in README.md ("computaiton" → "computation") and early-exit input validation added to the _wait_for_port helper in tests/integration/conftest.py. Both changes are correct and safe.

Confidence Score: 5/5

Safe to merge — changes are a documentation typo fix and a harmless test-helper guard with no risk of regression.

Both changes are minimal, correct, and non-breaking. The validation logic in _wait_for_port is consistent with the existing loop semantics (a non-positive timeout or interval would either skip the loop entirely or spin infinitely, so rejecting them early is strictly better). No P0 or P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
README.md Fixes typo "computaiton" → "computation" on line 21; straightforward documentation correction.
tests/integration/conftest.py Adds early ValueError guards for non-positive timeout and interval in _wait_for_port; logic is correct and consistent with the existing loop behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[_wait_for_port called] --> B{timeout <= 0?}
    B -- Yes --> C[raise ValueError]
    B -- No --> D{interval <= 0?}
    D -- Yes --> E[raise ValueError]
    D -- No --> F[Set deadline]
    F --> G{Before deadline?}
    G -- No --> H[raise TimeoutError]
    G -- Yes --> I[Try socket connect]
    I -- Success --> J[return]
    I -- Failure --> K[Store err, sleep interval]
    K --> G
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into docs/fix-readme..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant