Fix typo and improve test infrastructure robustness#1797
Fix typo and improve test infrastructure robustness#1797RobbiWillm wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
- Fix 'computaiton' typo in README.md - Add input validation to _wait_for_port in tests/integration/conftest.py to prevent invalid timeout/interval values This improves test reliability by catching configuration errors early. Signed-off-by: RobbiWillm <23glories.novas@icloud.com>
Greptile SummaryThis PR makes two minor improvements: a spelling fix in
|
| Filename | Overview |
|---|---|
| README.md | Fixes typo "computaiton" → "computation" on line 21; straightforward documentation correction. |
| tests/integration/conftest.py | Adds early ValueError guards for non-positive timeout and interval in _wait_for_port; logic is correct and consistent with the existing loop behavior. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[_wait_for_port called] --> B{timeout <= 0?}
B -- Yes --> C[raise ValueError]
B -- No --> D{interval <= 0?}
D -- Yes --> E[raise ValueError]
D -- No --> F[Set deadline]
F --> G{Before deadline?}
G -- No --> H[raise TimeoutError]
G -- Yes --> I[Try socket connect]
I -- Success --> J[return]
I -- Failure --> K[Store err, sleep interval]
K --> G
Reviews (2): Last reviewed commit: "Merge branch 'main' into docs/fix-readme..." | Re-trigger Greptile
Summary
This PR makes two small improvements:
_wait_for_portfunction in integration test conftest.pyChanges
README.md
tests/integration/conftest.py
_wait_for_porthelperTesting
The conftest.py change improves test reliability by catching configuration errors early rather than hanging or producing confusing timeout errors.
Note: Changes to test infrastructure may benefit from running integration tests to verify no regressions.