Forward-merge release/0.7 into main

[willkill07]

Overview

Forward-merge release/0.7 into main after the automated forward-merger PR encountered conflicts.

• I confirm this contribution is my own work, or I have the right to submit it under this project's license.
• I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

• Preserve the complete main and release/0.7 histories in a merge commit.
• Resolve the npm workspace conflict by retaining the 0.8 versions for the surviving Node.js and OpenClaw packages while applying the release branch's intentional removal of the retired npm CLI package.
• Keep the original automated forward-merge PR open so it can reconcile after this manual merge lands.

Merge requirement: An admin must merge this PR with GitHub's Create a Merge Commit strategy. Do not use the auto-merger or a /merge comment; squashing or rebasing would lose the release branch history.

Validation:

• cargo fmt --all passed.
• cargo clippy --workspace --all-targets -- -D warnings passed.
• Merge-conflict commit hooks passed, including JSON validation, docs links, lockfile consistency, and Node attribution generation.
• just test-rust: 1,177 passed and one parallel global-registration test failed; that test passed on an immediate isolated rerun.
• just test-python: 628 passed; 11 failures resulted from the pre-existing /Users/wkillian/.nemo-relay/plugins.toml being inherited, with the first warning leaving static state active and cascading into the dynamic-host tests.
• just test-go was interrupted at the request to proceed directly with publishing. just test-node and the all-files pre-commit suite were not run.

Where should the reviewer start?

Start with the merge commit's resolution of package-lock.json and deletion of packages/cli-bin/package.json, then verify that both parents of the merge commit are preserved.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• Relates to Forward-merge release/0.7 into main #709

Summary by CodeRabbit

• New Features

  • Coding-agent hooks now apply event-specific failure policies: permission checks fail closed, while lifecycle hooks fail open.
  • Added explicit --fail-open and --fail-closed options for hook forwarding.
  • Added dynamic plugin activation loading from plugins.toml.
  • Added default operational logging lifecycle support across language integrations.
  • Error telemetry now preserves callback exception types.

• Documentation

  • CLI installation guidance now prioritizes PyPI, pip, uv, Cargo, and scripts; npm CLI packages are retired.
  • Switchyard integration is marked deprecated and planned for removal in Relay 0.8.

[coderabbitai]

Walkthrough

This PR retires CLI npm packaging, adds event-specific coding-agent hook policies, improves callback error and OpenTelemetry metadata, adds default logging lifecycle APIs across bindings, introduces Python dynamic plugin loading, and updates plugin cleanup and documentation.

Changes

Release and packaging

Layer / File(s)	Summary
CLI npm retirement and PyPI packaging .github/*, .gitlab-ci.yml, README.md, RELEASING.md, justfile, package.json, scripts/*	CLI npm artifacts and installation paths are removed. CI and publishing validate and publish Python wheels and Node packages only.
Event-specific hook failure policies crates/cli/src/hooks/*, crates/cli/src/agents/*, integrations/coding-agents/*, crates/cli/tests/*	Generated hooks now select fail-open or fail-closed commands by event. Trust, migration, installation, validation, and tests use GeneratedHookCommands.
Observability and plugin cleanup crates/core/src/error.rs, crates/core/src/observability/*, crates/core/src/plugin.rs, crates/core/tests/*	Callback exceptions retain source types. Spans propagate descendant errors. Destinations use canonical comparison. Cleanup reports distinguish removed registrations from incomplete cleanup.
Binding logging and callback errors crates/ffi/*, crates/node/*, crates/python/src/*, go/nemo_relay/*	Bindings initialize default logging and expose shutdown behavior. Node and Python callback failures preserve exception types.
Dynamic plugin loading and documentation python/nemo_relay/plugin.py, python/tests/*, docs/*, crates/switchyard/*, examples/switchyard/*	Python loads dynamic activation specifications from plugins.toml. Documentation covers logging, hooks, observability, compatibility loading, and Switchyard deprecation.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• NVIDIA/NeMo-Relay#686: Overlaps in OpenTelemetry observability and plugin shutdown handling.
• NVIDIA/NeMo-Relay#692: Overlaps in event-specific fail-closed coding-agent hooks.
• NVIDIA/NeMo-Relay#694: Overlaps in the Python dynamic plugin TOML loader.

Suggested labels: DO NOT MERGE, duplicate

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name	Status	Explanation	Resolution
Title check	❌ Error	The title describes the merge but does not use the required Conventional Commits format or an allowed lowercase type.	Rename it with an allowed type, such as chore: forward-merge release/0.7 into main, and keep the summary concise without a trailing period.
Docstring Coverage	⚠️ Warning	Docstring coverage is 67.31% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description includes all required sections, checkboxes, change details, reviewer guidance, related issue, and validation results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Fern docs preview: https://nvidia-preview-pull-request-711.docs.buildwithfern.com/nemo/relay/dev

[github-actions]

License Diff

Compared against origin/main.

Lockfile license changes

Lockfile License Changes

Rust

Added

• None

Removed

• None

Updated/Changed

• None

Node

Added

• None

Removed

• None

Updated/Changed

• None

Python

Added

• None

Removed

• None

Updated/Changed

• None

Status output

[license-diff] selected languages: rust, node, python
[license-diff] generating current inventory
[license-diff] current: generating Rust inventory
[license-diff] current: Rust inventory complete (449 packages)
[license-diff] current: generating Node inventory
[license-diff] current: Node inventory complete (367 packages)
[license-diff] current: generating Python inventory
[license-diff] current: Python inventory complete (105 packages)
[license-diff] current inventory complete
[license-diff] checking out base ref origin/main into a temporary worktree
[license-diff] base: generating Rust inventory
[license-diff] base: Rust inventory complete (449 packages)
[license-diff] base: generating Node inventory
[license-diff] base: Node inventory complete (367 packages)
[license-diff] base: generating Python inventory
[license-diff] base: Python inventory complete (105 packages)
[license-diff] base inventory complete
[license-diff] removing temporary base worktree
[license-diff] comparing inventories
[license-diff] rendering Markdown output
[license-diff] done

[coderabbitai]

Actionable comments posted: 10

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

crates/cli/tests/coverage/agents/plugin_host_tests.rs (1)

111-131: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use the canonical Codex event mapping in the fallback.

When hooks.json has no matching entry, event can be pre_tool_use. for_event("pre_tool_use") selects the fail-open command because the policy classifier requires PreToolUse. The helper can then mask a fail-closed policy error in malformed or incomplete hook-file tests.

Proposed fix

-        .unwrap_or_else(|| expected_plugin_command().for_event(event).to_owned())
+        .unwrap_or_else(|| {
+            let commands = expected_plugin_command();
+            expected_codex_hook_command(&commands, event)
+                .expect("supported Codex hook event")
+                .to_owned()
+        })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/cli/tests/coverage/agents/plugin_host_tests.rs` around lines 111 -
131, Update the fallback in expected_plugin_command_for_hooks to use the
canonical event mapping before calling expected_plugin_command().for_event,
converting normalized hook names such as "pre_tool_use" to the corresponding
policy event "PreToolUse" so fail-closed behavior is preserved when hooks.json
has no matching entry.

crates/node/tests/llm_tests.mjs (1)

291-305: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add exception.type coverage for rejected LLM callbacks. The existing assertion covers only synchronous llmCallExecute; the asynchronous test checks only the rejection message. Add coverage for an llmCallExecuteAsync callback rejection, then run just test-node.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/node/tests/llm_tests.mjs` around lines 291 - 305, Extend the Node LLM
error tests near the existing synchronous llmCallExecute assertion to cover a
rejected callback from llmCallExecuteAsync, asserting both the rejection message
and exception.type. Keep the existing synchronous coverage intact, and run just
test-node to verify the tests.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/core/src/error.rs`:
- Around line 132-140: Mark the public FlowError enum as non-exhaustive and
update existing exhaustive FlowError matches, including integration-test
matches, with a fallback arm. Preserve the existing CallbackException handling
in FFI and native status mappings while keeping Python and Node string
conversion behavior unchanged.

In `@crates/core/src/observability/plugin_component.rs`:
- Around line 2548-2563: The non-loopback branch of canonical_opentelemetry_host
must normalize trailing dots by returning the computed domain rather than the
raw host. Update crates/core/src/observability/plugin_component.rs lines
2548-2563 accordingly, and extend the collision table in
crates/core/tests/unit/observability/plugin_component_tests.rs lines 2782-2783
with equivalent collector.example. and collector.example URLs.

In `@crates/core/tests/unit/observability/plugin_component_tests.rs`:
- Around line 2782-2783: Update canonical_opentelemetry_host in the non-loopback
hostname handling to remove a trailing dot before returning the canonical host,
while preserving loopback normalization. Add table coverage for
collector.example. and collector.example resolving to the same endpoint.

In `@crates/core/tests/unit/shared_tests.rs`:
- Around line 145-168: Add a negative assertion in the shared metadata tests
using FlowError::Internal to verify metadata_with_otel_error omits the
"exception.type" attribute for non-callback errors, while preserving the
existing callback-derived and caller-override assertions.

In `@crates/ffi/nemo_relay.h`:
- Around line 448-455: Update nemo_relay_initialize_default_logging and its Rust
FFI implementation so default logging initialization does not hard-code the
runtime identity as “go”; accept the caller’s binding name or introduce a
Go-specific wrapper while keeping the generic API identity-neutral. Update the
associated Rust documentation and regenerate crates/ffi/nemo_relay.h to match
the revised FFI surface.

In `@crates/ffi/tests/unit/api_tests.rs`:
- Around line 246-257: The logging lifecycle tests currently cover repeated
shutdown but not the documented idempotent initialization behavior. Add a test
alongside default_logging_shutdown_is_idempotent that acquires TEST_MUTEX, calls
api::nemo_relay_initialize_default_logging() twice expecting
NemoRelayStatus::Ok, then calls api::nemo_relay_shutdown_default_logging() for
cleanup; isolate the test in a child process like
configure_rejects_preinstalled_foreign_logger if the process-global logger could
affect other tests.

In `@crates/node/src/callable.rs`:
- Around line 212-221: Update safe_middleware_callback to preserve synchronous
callback exception metadata by safely extracting error.name and including it as
exceptionType in the returned failure envelope. Ensure the resulting path
supplies a non-empty exception type so it selects FlowError::CallbackException
rather than FlowError::Internal, while retaining the existing error message.

In `@crates/node/src/callback_factory.rs`:
- Around line 201-214: Update the synchronous callback failure handling in the
wrapper around the errorMessage/errorName extraction to preserve thrown
primitive values, matching the behavior used by callPromise. For strings,
numbers, and null, use the thrown value in the returned error field before
attempting object-property access, while retaining the existing message and
exceptionType handling for objects.

In `@go/nemo_relay/nemo_relay.go`:
- Around line 303-307: Document the Go binding’s fail-fast logging behavior next
to ShutdownLogging in go/nemo_relay/README.md, stating that invalid
NEMO_RELAY_LOG values cause init to panic during module loading. Keep the
existing init behavior unless implementing the alternative InitializeLogging()
error API is explicitly required.

In `@RELEASING.md`:
- Line 36: Update both GitHub Release asset descriptions in RELEASING.md,
including the entries around the Node npm tarballs, to explicitly list the
retained nemo-relay-openclaw tarball alongside the existing release artifacts.

---

Outside diff comments:
In `@crates/cli/tests/coverage/agents/plugin_host_tests.rs`:
- Around line 111-131: Update the fallback in expected_plugin_command_for_hooks
to use the canonical event mapping before calling
expected_plugin_command().for_event, converting normalized hook names such as
"pre_tool_use" to the corresponding policy event "PreToolUse" so fail-closed
behavior is preserved when hooks.json has no matching entry.

In `@crates/node/tests/llm_tests.mjs`:
- Around line 291-305: Extend the Node LLM error tests near the existing
synchronous llmCallExecute assertion to cover a rejected callback from
llmCallExecuteAsync, asserting both the rejection message and exception.type.
Keep the existing synchronous coverage intact, and run just test-node to verify
the tests.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 779254db-b3a6-40d5-a83c-6fbd3ede4697

📥 Commits

Reviewing files that changed from the base of the PR and between c2c3db3 and ba13a12.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (92)

• .github/ci-path-filters.yml
• .github/workflows/ci.yaml
• .github/workflows/ci_rust.yml
• .gitlab-ci.yml
• README.md
• RELEASING.md
• crates/cli/README.md
• crates/cli/src/agents/claude/launch.rs
• crates/cli/src/agents/codex/host.rs
• crates/cli/src/agents/codex/launch.rs
• crates/cli/src/agents/hermes/config.rs
• crates/cli/src/agents/hermes/integration.rs
• crates/cli/src/agents/hermes/trust.rs
• crates/cli/src/agents/mod.rs
• crates/cli/src/bootstrap/mod.rs
• crates/cli/src/commands/hook_forward.rs
• crates/cli/src/hooks/delivery.rs
• crates/cli/src/hooks/encoding.rs
• crates/cli/src/hooks/mod.rs
• crates/cli/src/hooks/types.rs
• crates/cli/tests/cli_tests.rs
• crates/cli/tests/coverage/agents/hermes_tests.rs
• crates/cli/tests/coverage/agents/plugin_host_tests.rs
• crates/cli/tests/coverage/agents/plugin_install_tests.rs
• crates/cli/tests/coverage/shared/bootstrap_tests.rs
• crates/cli/tests/coverage/shared/installer_tests.rs
• crates/cli/tests/fixtures/windows_hook_relay.rs
• crates/core/src/api/shared.rs
• crates/core/src/error.rs
• crates/core/src/logging/mod.rs
• crates/core/src/observability/otel.rs
• crates/core/src/observability/plugin_component.rs
• crates/core/src/plugin.rs
• crates/core/src/plugin/dynamic/native.rs
• crates/core/tests/coverage/error_tests.rs
• crates/core/tests/coverage/logging_tests.rs
• crates/core/tests/integration/atif_storage_tests.rs
• crates/core/tests/unit/observability/otel_tests.rs
• crates/core/tests/unit/observability/plugin_component_tests.rs
• crates/core/tests/unit/plugin_tests.rs
• crates/core/tests/unit/shared_tests.rs
• crates/ffi/nemo_relay.h
• crates/ffi/src/api/mod.rs
• crates/ffi/src/error.rs
• crates/ffi/tests/coverage/error_tests.rs
• crates/ffi/tests/unit/api_tests.rs
• crates/node/src/api/mod.rs
• crates/node/src/callable.rs
• crates/node/src/callback_factory.rs
• crates/node/src/promise_call.rs
• crates/node/tests/llm_tests.mjs
• crates/node/tests/logging_tests.mjs
• crates/node/tests/tools_tests.mjs
• crates/python/src/lib.rs
• crates/python/src/py_api/mod.rs
• crates/python/src/py_callable.rs
• crates/python/src/py_plugin.rs
• crates/python/tests/coverage/py_plugin_coverage_tests.rs
• crates/switchyard/README.md
• docs/about-nemo-relay/release-notes/index.mdx
• docs/configure-plugins/about.mdx
• docs/configure-plugins/observability/atif.mdx
• docs/configure-plugins/observability/configuration.mdx
• docs/configure-plugins/observability/opentelemetry.mdx
• docs/configure-plugins/plugin-configuration-files.mdx
• docs/configure-plugins/switchyard/about.mdx
• docs/configure-plugins/switchyard/configuration.mdx
• docs/getting-started/installation.mdx
• docs/index.yml
• docs/nemo-relay-cli/basic-usage.mdx
• docs/reference/operational-logging.mdx
• examples/switchyard/README.md
• go/nemo_relay/README.md
• go/nemo_relay/logging_test.go
• go/nemo_relay/nemo_relay.go
• integrations/coding-agents/README.md
• integrations/coding-agents/claude-code/hooks/hooks.json
• integrations/coding-agents/codex/hooks/hooks.json
• justfile
• package.json
• packages/cli-bin/package.json
• python/nemo_relay/__init__.py
• python/nemo_relay/_native.pyi
• python/nemo_relay/plugin.py
• python/nemo_relay/plugin.pyi
• python/tests/test_dynamic_plugin_host.py
• python/tests/test_llm.py
• python/tests/test_logging.py
• python/tests/test_observability_plugin.py
• python/tests/test_tools.py
• scripts/package-cli-bin.py
• scripts/tests/test_package_cli_bin.py

💤 Files with no reviewable changes (5)

• packages/cli-bin/package.json
• crates/cli/README.md
• README.md
• .github/workflows/ci.yaml
• .github/ci-path-filters.yml