refactor(cli): share file-backed plugin activation - #685
Draft
bbednarski9 wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
bbednarski9
force-pushed
the
refactor/cli-plugin-file-activation
branch
from
August 4, 2026 11:48
9a4e7d4 to
22cf84e
Compare
bbednarski9
force-pushed
the
refactor/cli-plugin-file-activation
branch
from
August 4, 2026 12:24
22cf84e to
23e3809
Compare
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
bbednarski9
force-pushed
the
refactor/cli-plugin-file-activation
branch
from
August 4, 2026 12:58
23e3809 to
d27b518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is the second, stacked change for #673. It migrates the NeMo Relay CLI runtime owner onto the file-backed activation foundation introduced by #684. Please review and land #684 first; this PR intentionally targets
feat/python-plugin-file-activationwhile both changes remain drafts.Details
PluginFileActivationandPluginHostActivationPlan.had_inputstate and redacted inherited-source diagnostics through normal server and transparent-run startup. A physical or explicit empty configuration now owns the same process-wide activation lease as static or dynamic configuration; true no-input startup remains inactive.DynamicPluginActivationSnapshotArcalready used for managed-bootstrap identity. Activation uses only the snapshot manifest and managed-environment references, with no fallback to mutable original paths.plugins.toml, or vice versa.Validation completed:
cargo test -p nemo-relay-cli— 1,204 library tests, 12 architecture tests, and 98 CLI integration tests passed.just test-rust— full Rust, native plugin, worker plugin, Python native-binding, CLI, FFI, and doctest matrix passed.cargo clippy --workspace --all-targets -- -D warningspassed.cargo fmt --all -- --checkandgit diff --checkpassed.uv run pre-commit run --all-filespassed.cargo package --locked --package nemo-relay-cli --allow-dirty --listconfirmed the migrated sources and tests remain in the CLI package; package metadata is unchanged in this stacked PR.There are no public CLI flags or configuration-format changes in this PR.
Where should the reviewer start?
Start with
crates/cli/src/server/mod.rs, especiallyinitialize_plugin_host()andplugin_host_activation_plan(). Then review theplugin_had_inputand diagnostics plumbing incrates/cli/src/configuration/mod.rs,crates/cli/src/commands/mod.rs, andcrates/cli/src/process/launcher.rs. The exact snapshot-identity, owned-lifecycle, rollback, and shutdown assertions are incrates/cli/tests/coverage/shared/server_tests.rsandconfig_tests.rs.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)