[CI] Update PR Template with claude review details#1404
Conversation
One bullet in the existing pre-review checklist directing authors and reviewers to use `/claude review` on complex PRs. NVIDIA org members can self-trigger it, so it doubles as a self-review path for non-trivial changes (CodeRabbit still runs on every PR; this is orthogonal). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a CLAUDE guidance rule requiring the PR template be used verbatim with ChangesPR Guidance Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
/claude review |
Adds two CRITICAL rules so Claude Code (and contributors using it) follow the project's PR conventions: - Use .github/PULL_REQUEST_TEMPLATE.md verbatim instead of the harness's default Summary/Test-plan format - Run /claude review on non-trivial PRs before merging Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
|
@claude is the PR template missing any other important details? |
|
Claude finished @kevalmorabia97's task in 53s —— View job PR Template Analysis
The template is in good shape. The existing checklist covers backward compatibility, third-party code/dependencies, tests, changelog, and now Claude review. Here are a few observations on what could be added, though none are critical: Potentially missing items:
Verdict: Nothing critical is missing. The current checklist + the Security Best Practices preamble + CI automation (pre-commit hooks, CodeRabbit security check) cover the important bases. The only item I'd consider adding is a security-sensitive-code checkbox, since it would force authors to actively acknowledge the security policy rather than passively scroll past the link — but it's a judgment call given that CI already enforces it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 476 476
Lines 51307 51307
=======================================
Hits 39371 39371
Misses 11936 11936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
What does this PR do?
Type of change: documentation
Adds a
Did you get Claude approval on this PR?bullet to the pre-review checklist in.github/PULL_REQUEST_TEMPLATE.md. Also adds two CRITICAL rules toCLAUDE.mdso Claude Code (and contributors using it) follow the project's PR conventions:.github/PULL_REQUEST_TEMPLATE.mdverbatim instead of the harness's default## Summary/## Test planformat/claude reviewon non-trivial PRs before mergingBuilds on #1400 (workflows added) and #1401 (proxy compat fixes).
Usage
N/A — documentation only.
Testing
/claude reviewon this PR as a smoke-test of the integration on a docs-only diffBefore your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/AAdditional Information
Related: #1400, #1401
Summary by CodeRabbit