Conversation
Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com>
📝 WalkthroughWalkthroughDependency version constraints in the GPT-OSS example requirements are tightened. The ChangesDependency Version Pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
examples/gpt-oss/requirements.txt (1)
1-2: Consider planning a migration to newer transformers.While this fix correctly resolves the immediate import errors, pinning to older versions of
kernelsandtrackiocreates long-term maintenance overhead. Newer versions oftransformers(5.0+) likely supporthuggingface_hub>=1.x, which would allow using the latest versions of all dependencies.Consider opening a follow-up issue to track upgrading
transformersand removing these upper bounds once the example code is compatible with transformers 5.0+.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/gpt-oss/requirements.txt` around lines 1 - 2, The requirements pinning in requirements.txt (kernels>=0.9.0,<0.13 and trackio<0.21) is a short-term workaround; open a follow-up issue to track upgrading to transformers 5.0+ and huggingface_hub>=1.x so these upper bounds can be removed, and update the example once compatibility is verified by testing with transformers 5.x; specifically note the packages "kernels" and "trackio" in the issue, plan to remove the <0.13 and <0.21 caps, and add a CI job that runs the example against transformers 5.x to confirm there are no import/runtime errors before lifting the pins.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@examples/gpt-oss/requirements.txt`:
- Around line 1-2: The requirements pinning in requirements.txt
(kernels>=0.9.0,<0.13 and trackio<0.21) is a short-term workaround; open a
follow-up issue to track upgrading to transformers 5.0+ and huggingface_hub>=1.x
so these upper bounds can be removed, and update the example once compatibility
is verified by testing with transformers 5.x; specifically note the packages
"kernels" and "trackio" in the issue, plan to remove the <0.13 and <0.21 caps,
and add a CI job that runs the example against transformers 5.x to confirm there
are no import/runtime errors before lifting the pins.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 92c68367-4fc3-4491-ae27-474f620b77a9
📒 Files selected for processing (1)
examples/gpt-oss/requirements.txt
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 75.68% 74.02% -1.67%
==========================================
Files 471 471
Lines 50400 53856 +3456
==========================================
+ Hits 38145 39865 +1720
- Misses 12255 13991 +1736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
What does this PR do?
Type of change: Bug fix
Cap kernels<0.13 and trackio<0.21 in examples/gpt-oss/requirements.txt. Both newer versions require huggingface_hub>=1.x, but the example's transformers pins huggingface_hub<1.0, so a fresh install breaks on import (Unsupported type for field 'import_name': str | None from kernels; cannot import name 'Volume' from trackio).
Usage
No API change. On transformers<5.0, override the config's warmup_steps with --warmup_ratio 0.03 --warmup_steps 0 (or edit the YAML), as already noted by the comment in configs/sft_*.yaml.
Testing
pip install -r examples/gpt-oss/requirements.txt
pip install transformers==4.57.3
pip install -r examples/gpt-oss/requirements.txt
pip install --upgrade transformers
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/AAdditional Information