[6034518] Remove return statement preventing remote auto tuning#1361
[6034518] Remove return statement preventing remote auto tuning#1361gcunhase merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: dmoodie <dmoodie@nvidia.com>
📝 WalkthroughWalkthroughThe change removes an early return statement in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test d816d70 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
===========================================
+ Coverage 66.37% 76.93% +10.56%
===========================================
Files 471 471
Lines 50487 50486 -1
===========================================
+ Hits 33509 38842 +5333
+ Misses 16978 11644 -5334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok to test 49299af |
|
/ok to test ddba7e3 |
What does this PR do?
Remove return statement from the code checking remote auto tuning config arguments since that results in skipping adding the actual remote tuning config to the trtexec cmd.
Root cause: The necessary flags do not get added to
self._base_cmd.extend(trtexec_args)when remote autotuning is enabled.Before fix:
After fix:
Notice that the remote autotuning and related flags are now included in the
trtexeccommand.Related PR: #1259
Summary by CodeRabbit
Bug Fixes