Skip to content

Enable runtime optimization#1358

Draft
grzegorz-k-karch wants to merge 3 commits intomainfrom
gkarch/runtime_opt
Draft

Enable runtime optimization#1358
grzegorz-k-karch wants to merge 3 commits intomainfrom
gkarch/runtime_opt

Conversation

@grzegorz-k-karch
Copy link
Copy Markdown
Contributor

@grzegorz-k-karch grzegorz-k-karch commented Apr 28, 2026

To do to undraft

  • Document runtime optimization
    • How to enable
    • Example results for ffn pruning

What does this PR do?

Type of change: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅ / ❌ / N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅ / ❌ / N/A
  • Did you write any new necessary tests?: ✅ / ❌ / N/A
  • Did you update Changelog?: ✅ / ❌ / N/A

Additional Information

Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 28, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 65aedc70-433a-4c05-915a-0bfa8ed7e5a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gkarch/runtime_opt

Comment @coderabbitai help to get the list of available commands and usage tips.

@grzegorz-k-karch grzegorz-k-karch self-assigned this Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://NVIDIA.github.io/Model-Optimizer/pr-preview/pr-1358/

Built to branch gh-pages at 2026-04-28 14:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 35.83333% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.75%. Comparing base (8eec6d4) to head (3041dc2).

Files with missing lines Patch % Lines
...opt/torch/nas/subblock_stats/calc_runtime_stats.py 35.64% 65 Missing ⚠️
...h/puzzletron/subblock_stats/calc_subblock_stats.py 18.18% 9 Missing ⚠️
.../subblock_stats/calc_subblock_params_and_memory.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1358      +/-   ##
==========================================
- Coverage   76.93%   76.75%   -0.18%     
==========================================
  Files         471      474       +3     
  Lines       50404    50589     +185     
==========================================
+ Hits        38776    38828      +52     
- Misses      11628    11761     +133     
Flag Coverage Δ
unit 52.72% <35.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grzegorz-k-karch grzegorz-k-karch changed the title enabling runtime optimization Enable runtime optimization Apr 28, 2026
Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant