-
Notifications
You must be signed in to change notification settings - Fork 375
Quantize lm_head + embedding for Nemotron-H, add NVFP4 W4A16 recipe #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajrasane
wants to merge
6
commits into
main
Choose a base branch
from
ajrasane/nemotron-3-nano
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43c3454
feat: quantize lm_head + embedding for Nemotron-H, add NVFP4 W4A16 re…
ajrasane 490b6b2
feat(ptq): align with PR #1313 — rename W4A16 recipe, first-class for…
ajrasane a115c88
fix(ptq): address PR #1327 review feedback
ajrasane 8fa0d4c
feat(ptq): replace Nemotron-H ad-hoc lm_head/embedding helper with YA…
ajrasane e63965e
chore(ptq): drop transformers 5.5.x Nemotron-H mixer-type monkey-patches
ajrasane 78f4c42
chore(ptq): drop --exclude_modules CLI flag (recipes own exclusions)
ajrasane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Quantized Embedding. | ||
|
|
||
| ``nn.Embedding`` quantization is weight-only: only the lookup table (``weight``) is | ||
| fake-quantized. Embedding inputs are integer indices — their ``input_quantizer`` is | ||
| registered (so config entries like ``"*input_quantizer"`` can still target it) but is | ||
| disabled by default so integer tensors pass through untouched. | ||
| """ | ||
|
|
||
| import torch.nn as nn | ||
|
|
||
| from ... import tensor_quant | ||
| from .quant_module import QuantLinearConvBase, QuantModuleRegistry | ||
|
|
||
| __all__ = ["QuantEmbedding"] | ||
|
|
||
|
|
||
| @QuantModuleRegistry.register({nn.Embedding: "nn.Embedding"}) | ||
| class _QuantEmbedding(QuantLinearConvBase): | ||
| """Quantized base class for ``nn.Embedding``. | ||
|
|
||
| Weight-only quantization. Input/output quantizers are created (so wildcard configs | ||
| still resolve cleanly) but are disabled — an embedding's input is an index tensor. | ||
| """ | ||
|
|
||
| default_quant_desc_weight = tensor_quant.QUANT_DESC_8BIT_LINEAR_WEIGHT_PER_ROW | ||
|
|
||
| def _setup(self): | ||
| super()._setup() | ||
| # Embedding inputs are integer indices; never fake-quantize them. | ||
| self.input_quantizer.disable() | ||
| # output_quantizer is already disabled by QuantInputBase._setup(). | ||
|
|
||
|
|
||
| # Alias to follow the naming convention of QuantLinear. | ||
| QuantEmbedding = _QuantEmbedding |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ajrasane , should we point the users to how they can convert? do we have a helper in ModelOpt we should point them to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hychiang-git, are you planning to merge your conversion script to modelopt?