Add opt-in nonuniform tensor parallelism#4585
Open
daiyaanarfeen wants to merge 1 commit intoNVIDIA:devfrom
Open
Add opt-in nonuniform tensor parallelism#4585daiyaanarfeen wants to merge 1 commit intoNVIDIA:devfrom
daiyaanarfeen wants to merge 1 commit intoNVIDIA:devfrom
Conversation
9643eef to
0c04f90
Compare
0c04f90 to
e756ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds opt-in nonuniform tensor parallelism support through isolated helper modules, including NTP-aware DDP/optimizer gradient resharding and a Transformer Engine userbuffer adapter for mixed TP-domain overlap setup.
Issue tracking
Linked issue: N/A. This is a NVIDIA-authored feature branch for internal NTP validation; no public GitHub issue is currently linked.
Contribution process
Pre-checks
Testing
SKIP_DOCS=true BASE_REF=dev /Users/darfeen/.cache/uv/bin/uv run bash tools/autoformat.shCHECK_ONLY=true SKIP_DOCS=true BASE_REF=dev /Users/darfeen/.cache/uv/bin/uv run bash tools/autoformat.sh/tmp/megatron-ntp-pr/.venv/bin/python -m py_compile megatron/core/distributed/nonuniform_tp.py megatron/core/extensions/nonuniform_tp_transformer_engine.py tests/unit_tests/distributed/test_nonuniform_tp.py tests/unit_tests/extension/test_nonuniform_tp_transformer_engine.py/tmp/megatron-ntp-pr/.venv/bin/python -c '<direct nonuniform_tp_transformer_engine helper smoke test>'Note: local pytest collection is blocked in this macOS uv environment because the repo excludes torch/triton from the default env; a one-off torch install then failed on missing triton during Megatron conftest import.