Reduce rollout broadcast memory usage and add safe optional torch.distributed import handling#4571
Open
brukcodes wants to merge 3 commits intoNVIDIA:mainfrom
Open
Reduce rollout broadcast memory usage and add safe optional torch.distributed import handling#4571brukcodes wants to merge 3 commits intoNVIDIA:mainfrom
brukcodes wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
brukcodes
changed the title
yobibyte
reviewed
May 1, 2026
| import torch.distributed as dist | ||
| try: | ||
| import torch.distributed as dist | ||
| HAS_TORCH_DISTRIBUTED = True |
Contributor
There was a problem hiding this comment.
How can you not have torch distributed here?
yobibyte
reviewed
May 1, 2026
| # Wait for Rollouts to be collected. Broadcast in small chunks to avoid | ||
| # pickling the entire `rollouts` list at once (which can cause large | ||
| # temporary allocations on rank 0). | ||
| for i in range(n_prompts): |
Contributor
There was a problem hiding this comment.
Could you confirm that this is indeed fixing what it claims to fix, please?
yobibyte
reviewed
May 1, 2026
Contributor
yobibyte
left a comment
yobibyte
left a comment
There was a problem hiding this comment.
Hey! Left a couple of Qs.
svcnvidia-nemo-ci
added
the
waiting-on-customer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.