ci: add cadence input for test filtering in CI workflows#4561
Draft
balasaajay wants to merge 7 commits intoNVIDIA:mainfrom
Draft
ci: add cadence input for test filtering in CI workflows#4561balasaajay wants to merge 7 commits intoNVIDIA:mainfrom
balasaajay wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
- Introduced a new `cadence` input in the GitHub Actions workflow to filter tests based on the trigger type (pr|nightly|mergegroup). - Updated the action YAML to include the `cadence` input and modified the test execution logic to respect this new parameter. - Enhanced documentation in SKILL.md to explain the cadence filter and its usage in test cases. - Updated relevant Python scripts to accept and process the `cadence` argument for test execution. - Adjusted existing recipes to include cadence values for better test management.
balasaajay
changed the title
Contributor
Author
|
/ok to test bc8b163 |
Contributor
Author
|
/ok to test ff867d8 |
Contributor
Author
|
/ok to test 9ff6021 |
Contributor
Author
|
/ok to test 015fda1 |
Contributor
Author
|
verified using workflow_dispatch - https://github.com/NVIDIA/Megatron-LM/actions/runs/25234600566 and with PR trigger - https://github.com/NVIDIA/Megatron-LM/actions/runs/25238441652?pr=4561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
cadenceinput in the GitHub Actions workflow to filter tests based on the trigger type (pr|nightly|mergegroup).cadenceinput and modified the test execution logic to respect this new parameter.cadenceargument for test execution.Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.